Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/config/compiler/BUILD.gn

Issue 1348493002: Add fnl build target (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/config/BUILDCONFIG.gn ('K') | « build/config/BUILDCONFIG.gn ('k') | build/config/features.gni » ('j') | build/config/fnl/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index f7797958044ce13f30fbba5f579e81fd282ed097..ce7b7c52768c1e887982cd737ce95d62cbdb1a55 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -975,7 +975,8 @@ config("chromium_code") {
"__STDC_FORMAT_MACROS",
]
- if (!using_sanitizer && (!is_linux || !is_clang || is_official_build)) {
+ if (!is_debug && !using_sanitizer &&
viettrungluu 2015/09/15 23:48:22 Why !is_debug?
cdotstout 2015/09/16 22:00:59 Because, as the comment below says, defining FORTI
+ (!is_linux || !is_clang || is_official_build)) {
# _FORTIFY_SOURCE isn't really supported by Clang now, see
# http://llvm.org/bugs/show_bug.cgi?id=16821.
# It seems to work fine with Ubuntu 12 headers though, so use it in
« build/config/BUILDCONFIG.gn ('K') | « build/config/BUILDCONFIG.gn ('k') | build/config/features.gni » ('j') | build/config/fnl/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698