chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java - Issue 1348473002: Fix size estimation for prerender in custom tabs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java

Issue 1348473002: Fix size estimation for prerender in custom tabs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added comments to size estimate Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTab.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java

index 6519f4afa973287015d4a536f4ce83cb52041bee..d0497c332315af465736d2b3b79aabf98e98d626 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java

@@ -5,6 +5,7 @@

package org.chromium.chrome.browser.customtabs;

import android.content.Intent;

+import android.graphics.Point;

import android.net.Uri;

import android.os.IBinder;

import android.support.customtabs.CustomTabsCallback;

@@ -172,7 +173,7 @@ public class CustomTabActivity extends ChromeActivity {

// prerendering doesn't support extra headers.

if (IntentHandler.getExtraHeadersFromIntent(getIntent()) != null) {

CustomTabsConnection.getInstance(getApplication())

- .takePrerenderedUrl(mSession, "", null);

+ .takePrerenderedUrl(mSession, "", null, new Point());

}

mTab = new CustomTab(this, getWindowAndroid(), mSession, url, referrerUrl,