Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: tool/input_sdk/private/native_typed_data.dart

Issue 1348453004: fix some errors in our SDK, mostly around numbers (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tool/input_sdk/private/js_string.dart ('k') | tool/sdk_expected_errors.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tool/input_sdk/private/native_typed_data.dart
diff --git a/tool/input_sdk/private/native_typed_data.dart b/tool/input_sdk/private/native_typed_data.dart
index 4f159126f512cb0ff620ef6ddf03d117c17c0c55..b70021d1ed7bc54e3ba95f07fabc96c7f080c38f 100644
--- a/tool/input_sdk/private/native_typed_data.dart
+++ b/tool/input_sdk/private/native_typed_data.dart
@@ -10,7 +10,7 @@ library dart.typed_data.implementation;
import 'dart:collection';
import 'dart:_internal';
-import 'dart:_interceptors' show JSIndexable, JSUInt32, JSUInt31;
+import 'dart:_interceptors' show JSIndexable;
import 'dart:_js_helper'
show Creates, JavaScriptIndexingBehavior, JSName, Native, Null, Returns;
import 'dart:_foreign_helper' show JS;
@@ -649,7 +649,7 @@ class NativeByteData extends NativeTypedData implements ByteData {
_getUint16(byteOffset, Endianness.LITTLE_ENDIAN == endian);
@JSName('getUint16')
- @Returns('JSUInt31')
+ @Returns('int')
int _getUint16(int byteOffset, [bool littleEndian]) native;
/**
@@ -665,7 +665,7 @@ class NativeByteData extends NativeTypedData implements ByteData {
_getUint32(byteOffset, Endianness.LITTLE_ENDIAN == endian);
@JSName('getUint32')
- @Returns('JSUInt32')
+ @Returns('int')
int _getUint32(int byteOffset, [bool littleEndian]) native;
/**
@@ -888,7 +888,7 @@ abstract class NativeTypedArrayOfDouble
extends NativeTypedArray
with ListMixin<double>, FixedLengthListMixin<double> {
- int get length => JS('JSUInt32', '#.length', this);
+ int get length => JS('int', '#.length', this);
double operator[](int index) {
_checkIndex(index, length);
@@ -915,7 +915,7 @@ abstract class NativeTypedArrayOfInt
with ListMixin<int>, FixedLengthListMixin<int>
implements List<int> {
- int get length => JS('JSUInt32', '#.length', this);
+ int get length => JS('int', '#.length', this);
// operator[]() is not here since different versions have different return
// types
@@ -1152,7 +1152,7 @@ class NativeUint16List extends NativeTypedArrayOfInt implements Uint16List {
int operator[](int index) {
_checkIndex(index, length);
- return JS('JSUInt31', '#[#]', this, index);
+ return JS('int', '#[#]', this, index);
}
List<int> sublist(int start, [int end]) {
@@ -1192,7 +1192,7 @@ class NativeUint32List extends NativeTypedArrayOfInt implements Uint32List {
int operator[](int index) {
_checkIndex(index, length);
- return JS('JSUInt32', '#[#]', this, index);
+ return JS('int', '#[#]', this, index);
}
List<int> sublist(int start, [int end]) {
@@ -1232,11 +1232,11 @@ class NativeUint8ClampedList
Type get runtimeType => Uint8ClampedList;
- int get length => JS('JSUInt32', '#.length', this);
+ int get length => JS('int', '#.length', this);
int operator[](int index) {
_checkIndex(index, length);
- return JS('JSUInt31', '#[#]', this, index);
+ return JS('int', '#[#]', this, index);
}
List<int> sublist(int start, [int end]) {
@@ -1280,11 +1280,11 @@ class NativeUint8List extends NativeTypedArrayOfInt implements Uint8List {
Type get runtimeType => Uint8List;
- int get length => JS('JSUInt32', '#.length', this);
+ int get length => JS('int', '#.length', this);
int operator[](int index) {
_checkIndex(index, length);
- return JS('JSUInt31', '#[#]', this, index);
+ return JS('int', '#[#]', this, index);
}
List<int> sublist(int start, [int end]) {
« no previous file with comments | « tool/input_sdk/private/js_string.dart ('k') | tool/sdk_expected_errors.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698