tool/input_sdk/private/js_array.dart - Issue 1348453004: fix some errors in our SDK, mostly around numbers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tool/input_sdk/private/js_array.dart

Issue 1348453004: fix some errors in our SDK, mostly around numbers (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tool/input_sdk/private/js_array.dart

diff --git a/tool/input_sdk/private/js_array.dart b/tool/input_sdk/private/js_array.dart

index 8fabaf3492a6e493348d7a8963f2c6760c396e01..6fa2d331d54006db9312d7a7184dd1e695e5de5c 100644

--- a/tool/input_sdk/private/js_array.dart

+++ b/tool/input_sdk/private/js_array.dart

@@ -298,7 +298,7 @@ class JSArray<E> implements List<E>, JSIndexable {

int get hashCode => Primitives.objectHashCode(this);

- int get length => JS('JSUInt32', r'#.length', this);

+ int get length => JS('int', r'#.length', this);

void set length(int newLength) {

if (newLength is !int) throw new ArgumentError(newLength);

« no previous file with comments | « tool/input_sdk/patch/typed_data_patch.dart ('k') | tool/input_sdk/private/js_helper.dart » ('j') | no next file with comments »