Issue 1348433002: Merge to XFA: Refactor fxjs_v8 and add embeddertests for it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1348433002: Merge to XFA: Refactor fxjs_v8 and add embeddertests for it. (Closed)

Created:
5 years, 3 months ago by Tom Sepez

Modified:
5 years, 3 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Refactor fxjs_v8 and add embeddertests for it. (cherry picked from commit b17d62601b21dfce85718e08cfd0ffce3a45d74e) (cherry picked from commit 09ed30750282bf56a92d0e646ab22c64bea81a36) Manual edits: fpdfsdk/src/jsapi/fxjs_v8_embeddertest.cpp - add lockers. fppdfsdk/src/javascript/JS_Runtime.cpp - rework XFA init path. Original Review URL: https://codereview.chromium.org/1338073002 . R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/7d0fcbf8198f04a5a5bd15482fdbdae919fb1891

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+133 lines, -51 lines)			Patch
M	BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	fpdfsdk/include/javascript/IJavaScript.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	fpdfsdk/include/javascript/JS_Runtime.h	View	3 chunks	+2 lines, -8 lines	0 comments	Download
M	fpdfsdk/include/jsapi/fxjs_v8.h	View	2 chunks	+24 lines, -6 lines	0 comments	Download
M	fpdfsdk/src/javascript/JS_Runtime.cpp	View	4 chunks	+8 lines, -26 lines	0 comments	Download
M	fpdfsdk/src/jsapi/fxjs_v8.cpp	View	4 chunks	+24 lines, -9 lines	0 comments	Download
A	fpdfsdk/src/jsapi/fxjs_v8_embeddertest.cpp	View	1 chunk	+71 lines, -0 lines	0 comments	Download
M	pdfium.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

Tom Sepez

5 years, 3 months ago (2015-09-15 22:30:37 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
7d0fcbf8198f04a5a5bd15482fdbdae919fb1891 (tree was closed).