Issue 134843008: Revert of Revert "Revert of https://codereview.chromium.org/129423002/"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 134843008: Revert of Revert "Revert of https://codereview.chromium.org/129423002/" (Closed)

Created:
6 years, 11 months ago by reed1

Modified:
6 years, 11 months ago

Reviewers:

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

Revert of https://codereview.chromium.org/132643007/ Reason for revert: broken tests TBR= NOTREECHECKS=true NOTRY=true BUG= Committed: http://code.google.com/p/skia/source/detail?r=13058

Created: 6 years, 11 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+46 lines, -114 lines)			Patch
M	include/core/SkBitmap.h	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	include/core/SkImageInfo.h	View	1 chunk	+0 lines, -54 lines	0 comments	Download
M	src/core/SkBitmap.cpp	View	1 chunk	+0 lines, -24 lines	0 comments	Download
M	src/core/SkImageFilterUtils.cpp	View	1 chunk	+8 lines, -2 lines	0 comments	Download
M	src/core/SkScaledImageCache.cpp	View	1 chunk	+8 lines, -4 lines	0 comments	Download
M	src/effects/gradients/SkGradientShader.cpp	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	src/image/SkImagePriv.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/image/SkImagePriv.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/image/SkImage_Base.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/image/SkImage_Raster.cpp	View	3 chunks	+10 lines, -7 lines	0 comments	Download
M	src/image/SkSurface_Raster.cpp	View	1 chunk	+6 lines, -3 lines	0 comments	Download
M	src/lazy/SkCachingPixelRef.cpp	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	src/lazy/SkDiscardablePixelRef.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/MallocPixelRefTest.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/PixelRefTest.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

reed1

Created Revert of Revert "Revert of https://codereview.chromium.org/129423002/"

6 years, 11 months ago (2014-01-13 20:38:51 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/134843008/1

6 years, 11 months ago (2014-01-13 20:38:57 UTC) #2

Message was sent while issue was closed.

Change committed as 13058