lib/klog/klog.c - Issue 1348403002: Consistently use the STATIC_COMMAND macro every time we define a console command.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: lib/klog/klog.c

Issue 1348403002: Consistently use the STATIC_COMMAND macro every time we define a console command. (Closed) Base URL: https://github.com/travisg/lk.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « lib/ffs/cmd.c ('k') | lib/lwip/cmd.c » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (c) 2013 Google, Inc.	2 * Copyright (c) 2013 Google, Inc.

3 *	3 *

4 * Permission is hereby granted, free of charge, to any person obtaining	4 * Permission is hereby granted, free of charge, to any person obtaining

5 * a copy of this software and associated documentation files	5 * a copy of this software and associated documentation files

6 * (the "Software"), to deal in the Software without restriction,	6 * (the "Software"), to deal in the Software without restriction,

7 * including without limitation the rights to use, copy, modify, merge,	7 * including without limitation the rights to use, copy, modify, merge,

8 * publish, distribute, sublicense, and/or sell copies of the Software,	8 * publish, distribute, sublicense, and/or sell copies of the Software,

9 * and to permit persons to whom the Software is furnished to do so,	9 * and to permit persons to whom the Software is furnished to do so,

10 * subject to the following conditions:	10 * subject to the following conditions:

(...skipping 591 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
602 printf("vec %d: base %p, len %zu\n", 1, vec[1].iov_base, vec[1].iov_len) ;	602 printf("vec %d: base %p, len %zu\n", 1, vec[1].iov_base, vec[1].iov_len) ;

603 } else {	603 } else {

604 printf("ERROR unknown command\n");	604 printf("ERROR unknown command\n");

605 goto usage;	605 goto usage;

606 }	606 }

607	607

608 return 0;	608 return 0;

609 }	609 }

610	610

611 STATIC_COMMAND_START	611 STATIC_COMMAND_START

612 { "klog", "commands for manipulating klog", &cmd_klog },	612 STATIC_COMMAND("klog", "commands for manipulating klog", &cmd_klog)

613 STATIC_COMMAND_END(klog);	613 STATIC_COMMAND_END(klog);

614	614

615 #endif // WITH_LIB_CONSOLE	615 #endif // WITH_LIB_CONSOLE

616	616

OLD	NEW