Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 1348403002: Consistently use the STATIC_COMMAND macro every time we define a console command. (Closed)

Created:
5 years, 3 months ago by gkalsi
Modified:
5 years, 3 months ago
Reviewers:
travisg, cpu1, cja
Base URL:
https://github.com/travisg/lk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[console] Use STATIC_COMMAND macro for all console command definitions BUG= Committed: a6c8b005dbea4cac3c198832ba1f4178572ca08e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -31 lines) Patch
M app/pcitests/pci_tests.c View 1 chunk +1 line, -1 line 0 comments Download
M app/stringtests/string_tests.c View 1 chunk +1 line, -1 line 0 comments Download
M arch/arm/arm/debug.c View 1 chunk +1 line, -1 line 0 comments Download
M dev/gpio/debug.c View 1 chunk +1 line, -1 line 0 comments Download
M lib/buildsig/buildsig.c View 1 chunk +1 line, -1 line 0 comments Download
M lib/cksum/debug.c View 1 chunk +4 lines, -4 lines 0 comments Download
M lib/debugcommands/debugcommands.c View 1 chunk +12 lines, -12 lines 0 comments Download
M lib/ffs/cmd.c View 1 chunk +1 line, -1 line 0 comments Download
M lib/klog/klog.c View 1 chunk +1 line, -1 line 0 comments Download
M lib/lwip/cmd.c View 1 chunk +1 line, -1 line 0 comments Download
M lib/ptable/ptable.c View 1 chunk +1 line, -1 line 0 comments Download
M lib/sysparam/sysparam.c View 1 chunk +1 line, -1 line 0 comments Download
M lib/version/version.c View 1 chunk +1 line, -1 line 0 comments Download
M platform/omap3/i2c.c View 1 chunk +1 line, -1 line 0 comments Download
M platform/power.c View 1 chunk +2 lines, -2 lines 0 comments Download
M platform/zynq/gpio.c View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
travisg
looks pretty good, put the [console] line first in the commit message, however.
5 years, 3 months ago (2015-09-16 21:54:06 UTC) #3
gkalsi
On 2015/09/16 21:54:06, travisg wrote: > looks pretty good, put the [console] line first in ...
5 years, 3 months ago (2015-09-16 22:01:19 UTC) #4
gkalsi
5 years, 3 months ago (2015-09-16 22:37:40 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a6c8b005dbea4cac3c198832ba1f4178572ca08e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698