Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1348393003: Revert "Populate EEP estimate in NQE" (Closed)

Created:
5 years, 3 months ago by Justin Donnelly
Modified:
5 years, 3 months ago
Reviewers:
tbansal1
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Populate EEP estimate in NQE" This reverts commit b112feef767d087d6c40deb88c983d61c085d457. NetworkQualityEstimatorTest failing on multiple bots. BUG=472685 TBR=tbansal@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/24e0899f3d9552d06c332e62a67008ae19042b02 Cr-Commit-Position: refs/heads/master@{#349246}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -517 lines) Patch
M chrome/browser/android/net/external_estimate_provider_android.h View 2 chunks +16 lines, -5 lines 0 comments Download
M chrome/browser/android/net/external_estimate_provider_android.cc View 3 chunks +17 lines, -17 lines 0 comments Download
M chrome/browser/android/net/external_estimate_provider_android_unittest.cc View 4 chunks +1 line, -38 lines 0 comments Download
M net/base/external_estimate_provider.h View 1 chunk +0 lines, -4 lines 0 comments Download
M net/base/network_quality_estimator.h View 5 chunks +3 lines, -32 lines 0 comments Download
M net/base/network_quality_estimator.cc View 6 chunks +5 lines, -66 lines 0 comments Download
M net/base/network_quality_estimator_unittest.cc View 12 chunks +47 lines, -335 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +0 lines, -20 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Justin Donnelly
TBR
5 years, 3 months ago (2015-09-16 22:05:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1348393003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1348393003/1
5 years, 3 months ago (2015-09-16 22:06:22 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-16 22:08:00 UTC) #4
commit-bot: I haz the power
5 years, 3 months ago (2015-09-16 22:08:43 UTC) #5
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/24e0899f3d9552d06c332e62a67008ae19042b02
Cr-Commit-Position: refs/heads/master@{#349246}

Powered by Google App Engine
This is Rietveld 408576698