Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 13483026: Change the CQ code to update R= line as done in depot_tools. (Closed)

Created:
7 years, 8 months ago by M-A Ruel
Modified:
5 years, 11 months ago
Reviewers:
Dirk Pranke, iannucci
CC:
chromium-reviews, cmp-cc_chromium.org, Dirk Pranke
Base URL:
https://git.chromium.org/chromium/tools/commit-queue.git@2_common
Visibility:
Public.

Description

Change the CQ code to update R= line as done in depot_tools. See https://codereview.chromium.org/13800021 for more details. R=iannucci@chromium.org BUG=76730

Patch Set 1 #

Patch Set 2 : Update with HEAD of depot_tools #

Patch Set 3 : Fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -18 lines) Patch
M pending_manager.py View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M tests/pending_manager_test.py View 11 chunks +18 lines, -17 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
M-A Ruel
This CL depends on the refactoring in depot_tools, in particular https://codereview.chromium.org/13800018.
7 years, 8 months ago (2013-04-08 21:45:44 UTC) #1
M-A Ruel
Updated
7 years, 8 months ago (2013-04-11 01:12:00 UTC) #2
Dirk Pranke
lgtm
7 years, 8 months ago (2013-04-11 01:14:48 UTC) #3
iannucci
7 years, 8 months ago (2013-04-11 01:15:46 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698