Unify the way cctest initalizes the VM for each test case.

test/cctest/cctest.h

 // Copyright 2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 33 matching lines @@
   static void Test##Name()
 #endif
 
 #ifndef DISABLED_TEST
 #define DISABLED_TEST(Name)                                              \
   static void Test##Name();                                              \
   CcTest register_test_##Name(Test##Name, __FILE__, #Name, NULL, false); \
   static void Test##Name()
 #endif
 
+#define EXTENSION_LIST(V)                                                \
+  V(GC_EXTENSION,    "v8/gc")                                            \
+  V(PRINT_EXTENSION, "v8/print")                                         \
+  V(TRACE_EXTENSION, "v8/trace")
+
+#define DEFINE_EXTENSION_ID(Name, Ident) Name##_ID,
+enum CcTestExtensionIds {
+  EXTENSION_LIST(DEFINE_EXTENSION_ID)
+  kMaxExtensions
+};
+#undef DEFINE_EXTENSION_ID
+
+#define DEFINE_EXTENSION_FLAG(Name, Ident) Name = 1 << Name##_ID,
+enum CcTestExtensionFlags {

[Sven Panne, 2013/04/09 07:26:28]

Using EnumSet here would be simpler and actually more readable. This avoids our
common confusion between an element and a set of elements on the type level.
Using "CcExtensionFlag" is a more appropriate then, too.

[Michael Starzinger, 2013/04/09 09:04:00]

Done.

+  NO_EXTENSIONS = 0,
+  EXTENSION_LIST(DEFINE_EXTENSION_FLAG)
+  ALL_EXTENSIONS = (1 << kMaxExtensions) - 1
+};
+#undef DEFINE_EXTENSION_FLAG
+
 class CcTest {
  public:
   typedef void (TestFunction)();
   CcTest(TestFunction* callback, const char* file, const char* name,
          const char* dependency, bool enabled);
   void Run() { callback_(); }
   static CcTest* last() { return last_; }
   CcTest* prev() { return prev_; }
   const char* file() { return file_; }
   const char* name() { return name_; }
   const char* dependency() { return dependency_; }
   bool enabled() { return enabled_; }
   static void set_default_isolate(v8::Isolate* default_isolate) {
     default_isolate_ = default_isolate;
   }
   static v8::Isolate* default_isolate() { return default_isolate_; }
+  static v8::Isolate* isolate() { return context_->GetIsolate(); }
+  static v8::Handle<v8::Context> env() { return context_; }
+
+  // Helper function to initialize the VM.
+  static void InitializeVM(int extensions = NO_EXTENSIONS);

[Sven Panne, 2013/04/09 07:26:28]

Use EnumSet<CcTestExtensionFlag> (or perhaps a typedef of it) as a parameter.

[Michael Starzinger, 2013/04/09 09:04:00]

Done.

 
  private:
   TestFunction* callback_;
   const char* file_;
   const char* name_;
   const char* dependency_;
   bool enabled_;
+  CcTest* prev_;
   static CcTest* last_;
-  CcTest* prev_;
   static v8::Isolate* default_isolate_;
+  static v8::Persistent<v8::Context> context_;
 };
 
 // Switches between all the Api tests using the threading support.
 // In order to get a surprising but repeatable pattern of thread
 // switching it has extra semaphores to control the order in which
 // the tests alternate, not relying solely on the big V8 lock.
 //
 // A test is augmented with calls to ApiTestFuzzer::Fuzz() in its
 // callbacks.  This will have no effect when we are not running the
 // thread fuzzing test.  In the thread fuzzing test it will
@@ skipping 166 matching lines @@
 static inline void SimulateFullSpace(v8::internal::PagedSpace* space) {
   int old_linear_size = static_cast<int>(space->limit() - space->top());
   space->Free(space->top(), old_linear_size);
   space->SetTop(space->limit(), space->limit());
   space->ResetFreeList();
   space->ClearStats();
 }
 
 
 #endif  // ifndef CCTEST_H_