Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 13483011: Call failure callback when failed to set custom wallpaper. (Closed)

Created:
7 years, 8 months ago by bshe
Modified:
7 years, 8 months ago
Reviewers:
flackr
CC:
chromium-reviews, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Call failure callback when failed to set custom wallpaper. BUG=226680 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194697

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_manager.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
bshe
Hi Rob. Could you please take a look at this trivial CL? A failure callback ...
7 years, 8 months ago (2013-04-08 14:56:56 UTC) #1
bshe
Could you please also take a look at this tiny CL. Thanks! On 2013/04/08 14:56:56, ...
7 years, 8 months ago (2013-04-15 16:08:53 UTC) #2
flackr
lgtm
7 years, 8 months ago (2013-04-15 17:19:24 UTC) #3
bshe
7 years, 8 months ago (2013-04-17 22:00:26 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r194697 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698