Add UI notifications for admin-provided SSL certificates.

Add UI notifications for admin-provided SSL certificates.

This change adds the necktie icon to the omnibox and a warning to the
website settings dropdown notifying the user that they have accessed
data through an admin-provided SSL certificate.

BUG=216495
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=196510

[Joao da Silva, 2013-04-08 14:58:59]

Looks reasonable to me, though I'm not familiar with much of the code involved.
lgtm from enterprise code POV.

https://codereview.chromium.org/13483010/diff/6001/chrome/browser/chromeos/cr...
File chrome/browser/chromeos/cros/cert_library.cc (right):

https://codereview.chromium.org/13483010/diff/6001/chrome/browser/chromeos/cr...
chrome/browser/chromeos/cros/cert_library.cc:613: crypto::OpenPersistentNSSDB();
This shouldn't go in.

[dconnelly, 2013-04-08 15:01:57]

https://codereview.chromium.org/13483010/diff/6001/chrome/browser/chromeos/cr...
File chrome/browser/chromeos/cros/cert_library.cc (right):

https://codereview.chromium.org/13483010/diff/6001/chrome/browser/chromeos/cr...
chrome/browser/chromeos/cros/cert_library.cc:613: crypto::OpenPersistentNSSDB();
On 2013/04/08 14:58:59, Joao da Silva wrote:
> This shouldn't go in.

Done.

[dconnelly, 2013-04-09 09:26:28]

Hi all, need some OWNERS reviews:

markusheintz: chrome/browser/ui/website_settings/ and
chrome/browser/ui/gtk/website_settings/
sky: chrome/browser/ui/views/ and chrome/browser/ui/toolbar/

[dconnelly, 2013-04-09 09:26:59]

and oshima: chrome/app/theme/

[Joao da Silva, 2013-04-09 09:30:38]

Daniel, the icons in this CL are not the final icons yet, right? Do you plan to
update them later?

[dconnelly1, 2013-04-09 09:35:04]

I'll update them before I submit this.  Sending this out now to get
reviews ASAP.

On Tue, Apr 9, 2013 at 11:30 AM,  <joaodasilva@chromium.org> wrote:
> Daniel, the icons in this CL are not the final icons yet, right? Do you plan
> to
> update them later?
>
> https://codereview.chromium.org/13483010/

[sky, 2013-04-09 14:33:23]

sky->pkasting

[Peter Kasting, 2013-04-13 00:42:59]

LGTM

https://codereview.chromium.org/13483010/diff/2002/chrome/browser/ui/toolbar/...
File chrome/browser/ui/toolbar/toolbar_model_impl.cc (right):

https://codereview.chromium.org/13483010/diff/2002/chrome/browser/ui/toolbar/...
chrome/browser/ui/toolbar/toolbar_model_impl.cc:74: #if defined(OS_CHROMEOS)
Nit: Bonus points if browser_policy_connector can be #included by everyone and
this function just returns false on non-CrOS.  That way the caller doesn't need
to be #ifdefed.

https://codereview.chromium.org/13483010/diff/2002/chrome/browser/ui/toolbar/...
chrome/browser/ui/toolbar/toolbar_model_impl.cc:76:
Profile::FromBrowserContext(web_contents->GetBrowserContext()))) {
Nit: Indent 4, not 8.

No {}.

[dconnelly, 2013-04-17 11:46:51]

Uploaded new omnibox icons from sgabriel.

https://codereview.chromium.org/13483010/diff/2002/chrome/browser/ui/toolbar/...
File chrome/browser/ui/toolbar/toolbar_model_impl.cc (right):

https://codereview.chromium.org/13483010/diff/2002/chrome/browser/ui/toolbar/...
chrome/browser/ui/toolbar/toolbar_model_impl.cc:74: #if defined(OS_CHROMEOS)
On 2013/04/13 00:42:59, Peter Kasting wrote:
> Nit: Bonus points if browser_policy_connector can be #included by everyone and
> this function just returns false on non-CrOS.  That way the caller doesn't
need
> to be #ifdefed.

Done.

https://codereview.chromium.org/13483010/diff/2002/chrome/browser/ui/toolbar/...
chrome/browser/ui/toolbar/toolbar_model_impl.cc:76:
Profile::FromBrowserContext(web_contents->GetBrowserContext()))) {
On 2013/04/13 00:42:59, Peter Kasting wrote:
> Nit: Indent 4, not 8.
> 
> No {}.

Done.

[markusheintz_, 2013-04-17 12:24:42]

LGTM

[oshima, 2013-04-18 18:46:30]

chrome/app/theme lgtm

[commit-bot: I haz the power, 2013-04-25 08:01:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dconnelly@chromium.org/13483010/50001

[commit-bot: I haz the power, 2013-04-25 08:17:29]

Sorry for I got bad news for ya.
Compile failed with a clobber build on android_dbg.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-04-25 08:54:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dconnelly@chromium.org/13483010/53004

[commit-bot: I haz the power, 2013-04-25 09:03:38]

Retried try job too often on mac_rel for step(s) base_unittests, browser_tests,
cacheinvalidation_unittests, check_deps, chromedriver2_unittests,
components_unittests, content_browsertests, content_unittests, crypto_unittests,
gpu_unittests, interactive_ui_tests, ipc_tests, jingle_unittests,
media_unittests, nacl_integration, net_unittests, ppapi_unittests,
printing_unittests, remoting_unittests, sql_unittests, sync_integration_tests,
sync_unit_tests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2013-04-25 15:25:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dconnelly@chromium.org/13483010/53004

[commit-bot: I haz the power, 2013-04-25 15:40:23]

Sorry for I got bad news for ya.
Compile failed with a clobber build on android_dbg.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-04-25 16:30:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dconnelly@chromium.org/13483010/53004

[commit-bot: I haz the power, 2013-04-25 16:45:57]

Sorry for I got bad news for ya.
Compile failed with a clobber build on android_clang_dbg.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_cl...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[Joao da Silva, 2013-04-25 17:02:24]

lgtm

[commit-bot: I haz the power, 2013-04-25 17:03:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dconnelly@chromium.org/13483010/68016

[commit-bot: I haz the power, 2013-04-25 21:54:01]

Change committed as 196510