Use MailboxManagerSync on android.

services/gles2/gpu_state.cc

Index: services/gles2/gpu_state.cc
diff --git a/services/gles2/gpu_state.cc b/services/gles2/gpu_state.cc
index 47439fe451415a62fbba34f056f07d423ba82300..403e6a61c840ebc6fed45263413f397d8caed869 100644
--- a/services/gles2/gpu_state.cc
+++ b/services/gles2/gpu_state.cc
@@ -5,13 +5,18 @@
 
 #include "services/gles2/gpu_state.h"
 
+#include "gpu/command_buffer/service/mailbox_manager_impl.h"
+#include "gpu/command_buffer/service/mailbox_manager_sync.h"
+
 namespace gles2 {
 
 GpuState::GpuState()
     : control_thread_("gpu_command_buffer_control"),
       sync_point_manager_(gpu::SyncPointManager::Create(true)),
       share_group_(new gfx::GLShareGroup),
-      mailbox_manager_(new gpu::gles2::MailboxManagerImpl) {
+      // TODO: use Impl on linux, Sync on android
+      // mailbox_manager_(new gpu::gles2::MailboxManagerImpl) {

[jamesr, 2015/09/17 22:23:13]

can you just leave a todo and not the commented-out code?  dead code is smelly

[cdotstout, 2015/09/17 22:31:09]

Yes, Linux fails with MailboxManagerSync.  

If the overall approach in this CL seems correct (yes? let me know if not) then
I will add a factory to create the appropriate mailbox manager for linux vs
android.

+      mailbox_manager_(new gpu::gles2::MailboxManagerSync) {
   control_thread_.Start();
 }