services/gles2/mailbox_manager_factory_sync.cc - Issue 1348283004: Use MailboxManagerSync on android.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: services/gles2/mailbox_manager_factory_sync.cc

Issue 1348283004: Use MailboxManagerSync on android. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: use factory to create appropriate mailbox manager Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4 //

	5

	6 #include "services/gles2/mailbox_manager_factory.h"

	7

	8 #include "gpu/command_buffer/service/mailbox_manager_sync.h"

	9

	10 namespace gles2 {

	11

	12 gpu::gles2::MailboxManager* MailboxManagerFactory::Create() {

	13 return new gpu::gles2::MailboxManagerSync;
	jamesr 2015/09/18 02:31:35 instead of having separate _sync and _nosync.cc we instead of having separate _sync and _nosync.cc we could just have one with an #if defined(OS_ANDROID). i think policy decisions made in code tend to be easier for developers to find than policy decisions made in the build system cdotstout 2015/09/18 15:51:40 Done. Show quoted text On 2015/09/18 02:31:35, jamesr wrote: > instead of having separate _sync and _nosync.cc we could just have one with an > #if defined(OS_ANDROID). i think policy decisions made in code tend to be easier > for developers to find than policy decisions made in the build system Done.
	14 }

	15

	16 } // namespace gles2

OLD	NEW