Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 134823005: Mojo: re-organize public tests (Closed)

Created:
6 years, 11 months ago by darin (slow to review)
Modified:
6 years, 11 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews, Aaron Boodman, viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Mojo: re-organize public tests Move sample service test to be with the rest of the bindings tests, and change it to not echo output by default. R=viettrungluu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244437

Patch Set 1 #

Patch Set 2 : fix common tests #

Total comments: 2

Patch Set 3 : fix mojob.sh and delete mojo_bindings_unittests target #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -2816 lines) Patch
M mojo/common/common_type_converters_unittest.cc View 1 3 chunks +12 lines, -2 lines 0 comments Download
M mojo/mojo.gyp View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M mojo/mojo_public.gypi View 1 2 5 chunks +51 lines, -48 lines 0 comments Download
D mojo/public/bindings/sample/sample_service.mojom View 1 2 3 1 chunk +0 lines, -51 lines 0 comments Download
D mojo/public/bindings/sample/sample_service_unittests.cc View 1 chunk +0 lines, -305 lines 0 comments Download
M mojo/public/tests/DEPS View 1 chunk +1 line, -3 lines 0 comments Download
A + mojo/public/tests/bindings/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
A + mojo/public/tests/bindings/array_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
A + mojo/public/tests/bindings/buffer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/public/tests/bindings/connector_unittest.cc View 7 chunks +8 lines, -8 lines 0 comments Download
A + mojo/public/tests/bindings/handle_passing_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/public/tests/bindings/math_calculator.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/tests/bindings/remote_ptr_unittest.cc View 6 chunks +8 lines, -8 lines 0 comments Download
A + mojo/public/tests/bindings/sample_factory.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/tests/bindings/sample_service.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/tests/bindings/sample_service_unittests.cc View 8 chunks +28 lines, -21 lines 0 comments Download
A + mojo/public/tests/bindings/simple_bindings_support.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/tests/bindings/simple_bindings_support.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/public/tests/bindings/test_structs.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/tests/bindings/type_conversion_unittest.cc View 10 chunks +11 lines, -11 lines 0 comments Download
D mojo/public/tests/bindings_array_unittest.cc View 1 chunk +0 lines, -84 lines 0 comments Download
D mojo/public/tests/bindings_connector_unittest.cc View 1 chunk +0 lines, -234 lines 0 comments Download
D mojo/public/tests/bindings_handle_passing_unittest.cc View 1 chunk +0 lines, -173 lines 0 comments Download
D mojo/public/tests/bindings_remote_ptr_unittest.cc View 1 chunk +0 lines, -176 lines 0 comments Download
D mojo/public/tests/bindings_type_conversion_unittest.cc View 1 chunk +0 lines, -233 lines 0 comments Download
D mojo/public/tests/buffer_unittest.cc View 1 chunk +0 lines, -112 lines 0 comments Download
D mojo/public/tests/math_calculator.mojom View 1 chunk +0 lines, -19 lines 0 comments Download
D mojo/public/tests/sample_factory.mojom View 1 chunk +0 lines, -30 lines 0 comments Download
D mojo/public/tests/simple_bindings_support.h View 1 chunk +0 lines, -51 lines 0 comments Download
D mojo/public/tests/simple_bindings_support.cc View 1 chunk +0 lines, -101 lines 0 comments Download
A + mojo/public/tests/system/DEPS View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/public/tests/system/core_cpp_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/tests/system/core_perftest.cc View 2 chunks +15 lines, -15 lines 0 comments Download
A + mojo/public/tests/system/core_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D mojo/public/tests/system_core_cpp_unittest.cc View 1 chunk +0 lines, -380 lines 0 comments Download
D mojo/public/tests/system_core_perftest.cc View 1 chunk +0 lines, -119 lines 0 comments Download
D mojo/public/tests/system_core_unittest.cc View 1 chunk +0 lines, -111 lines 0 comments Download
D mojo/public/tests/test_structs.mojom View 1 chunk +0 lines, -19 lines 0 comments Download
A + mojo/public/tests/utility/bindings_support_impl_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/tests/utility/run_loop_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/tests/utility/thread_local_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D mojo/public/utility/DEPS View 1 chunk +0 lines, -11 lines 0 comments Download
D mojo/public/utility/bindings_support_impl_unittest.cc View 1 chunk +0 lines, -112 lines 0 comments Download
D mojo/public/utility/run_loop_unittest.cc View 1 chunk +0 lines, -192 lines 0 comments Download
M mojo/public/utility/thread_local.h View 2 chunks +3 lines, -5 lines 0 comments Download
D mojo/public/utility/thread_local_unittest.cc View 1 chunk +0 lines, -170 lines 0 comments Download
M mojo/tools/mojob.sh View 1 2 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
darin (slow to review)
This is the re-org of mojo/public/tests that we discussed.
6 years, 11 months ago (2014-01-11 00:33:25 UTC) #1
darin (slow to review)
https://codereview.chromium.org/134823005/diff/50001/mojo/common/common_type_converters_unittest.cc File mojo/common/common_type_converters_unittest.cc (right): https://codereview.chromium.org/134823005/diff/50001/mojo/common/common_type_converters_unittest.cc#newcode36 mojo/common/common_type_converters_unittest.cc:36: BindingsSupportImpl bindings_support_; This change is about keeping SimpleBindingsSupport internal ...
6 years, 11 months ago (2014-01-11 00:41:28 UTC) #2
darin (slow to review)
https://codereview.chromium.org/134823005/diff/50001/mojo/public/utility/thread_local.h File mojo/public/utility/thread_local.h (right): https://codereview.chromium.org/134823005/diff/50001/mojo/public/utility/thread_local.h#newcode51 mojo/public/utility/thread_local.h:51: #ifndef _WIN32 This change is about eliminating dependencies on ...
6 years, 11 months ago (2014-01-11 00:43:11 UTC) #3
viettrungluu
Could you also update the list of tests in tools/mojob.sh? (One day, I'll make that ...
6 years, 11 months ago (2014-01-11 00:51:12 UTC) #4
viettrungluu
On 2014/01/11 00:51:12, viettrungluu wrote: > Could you also update the list of tests in ...
6 years, 11 months ago (2014-01-11 00:52:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/134823005/180001
6 years, 11 months ago (2014-01-12 05:24:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/134823005/340001
6 years, 11 months ago (2014-01-12 06:13:37 UTC) #7
darin (slow to review)
6 years, 11 months ago (2014-01-12 06:19:09 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 manually as r244437 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698