Add clang tool to rewrite scoped_array<T> to scoped_ptr<T[]>.

Add clang tool to rewrite scoped_array<T> to scoped_ptr<T[]>.

BUG=171111
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192700

[dcheng, 2013-04-06 03:47:45]

Whee!

[Nico, 2013-04-06 04:24:26]

basically lgtm, but I'd fold that one class into main() I think.

https://codereview.chromium.org/13482006/diff/1/tools/clang/rewrite_scoped_ar...
File tools/clang/rewrite_scoped_array/RewriteScopedArray.cpp (right):

https://codereview.chromium.org/13482006/diff/1/tools/clang/rewrite_scoped_ar...
tools/clang/rewrite_scoped_array/RewriteScopedArray.cpp:52: };
Does this class add anything? Can't you dod the one call to addMatcher()
directly in main()?

https://codereview.chromium.org/13482006/diff/1/tools/clang/rewrite_scoped_ar...
tools/clang/rewrite_scoped_array/RewriteScopedArray.cpp:73: if
(!StringRef(replacement_text).startswith("scoped_array<") ||
This will ignore code with spaces or newlines between "scoped_array" and "<".
(Probably doesn't matter.)

https://codereview.chromium.org/13482006/diff/1/tools/clang/rewrite_scoped_ar...
tools/clang/rewrite_scoped_array/RewriteScopedArray.cpp:77:
replacement_text.insert(replacement_text.size() - 1, "[]");
This might not work if the type comes from a typeof
(`scoped_array<typeof(sin(4))>`) or from a macro, but I guess it's good enough
in practice.

[dcheng, 2013-04-06 04:33:36]

https://codereview.chromium.org/13482006/diff/1/tools/clang/rewrite_scoped_ar...
File tools/clang/rewrite_scoped_array/RewriteScopedArray.cpp (right):

https://codereview.chromium.org/13482006/diff/1/tools/clang/rewrite_scoped_ar...
tools/clang/rewrite_scoped_array/RewriteScopedArray.cpp:52: };
On 2013/04/06 04:24:26, Nico wrote:
> Does this class add anything? Can't you dod the one call to addMatcher()
> directly in main()?

In theory, it makes this more testable in case I update the tool driver to be
written in C++. In practice, I guess it doesn't really matter and I'll just fold
this into main().

https://codereview.chromium.org/13482006/diff/1/tools/clang/rewrite_scoped_ar...
tools/clang/rewrite_scoped_array/RewriteScopedArray.cpp:73: if
(!StringRef(replacement_text).startswith("scoped_array<") ||
On 2013/04/06 04:24:26, Nico wrote:
> This will ignore code with spaces or newlines between "scoped_array" and "<".
> (Probably doesn't matter.)

Yeah. I'm assuming that's not going to a very common case.

https://codereview.chromium.org/13482006/diff/1/tools/clang/rewrite_scoped_ar...
tools/clang/rewrite_scoped_array/RewriteScopedArray.cpp:77:
replacement_text.insert(replacement_text.size() - 1, "[]");
On 2013/04/06 04:24:26, Nico wrote:
> This might not work if the type comes from a typeof
> (`scoped_array<typeof(sin(4))>`) or from a macro, but I guess it's good enough
> in practice.

What typically happens is it emits multiple replacements for the same location.
This results in various syntax errors when trying to build the result, so it's
generally not undetected.

In the future, I'd like to add a facility for detecting conflicting rewrites in
run_tool.py to make these even more obvious.

[dcheng, 2013-04-06 04:50:48]

Committed patchset #2 manually as r192700 (presubmit successful).