Dartium JS Enabled take 2

tools/dom/templates/html/impl/impl_Node.darttemplate

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of $LIBRARYNAME;
 
 /**
  * Lazy implementation of the child nodes of an element that does not request
  * the actual child nodes of an element until strictly necessary greatly
  * improving performance for the typical cases where it is not required.
@@ skipping 96 matching lines @@
     var result = this[index];
     if (result != null) {
       _this._removeChild(result);
     }
     return result;
   }
 
   bool remove(Object object) {
     if (object is! Node) return false;
     Node node = object;
+$if JSINTEROP
+    // We aren't preserving identity of nodes in JSINTEROP mode
+    if (_this != node.parentNode) return false;
+$else
     if (!identical(_this, node.parentNode)) return false;
+$endif
     _this._removeChild(node);
     return true;
   }
 
   void _filter(bool test(Node node), bool removeMatching) {
     // This implementation of removeWhere/retainWhere is more efficient
     // than the default in ListBase. Child nodes can be removed in constant
     // time.
     Node child = _this.firstChild;
     while (child != null) {
@@ skipping 43 matching lines @@
 
   void fillRange(int start, int end, [Node fill]) {
     throw new UnsupportedError("Cannot fillRange on Node list");
   }
   // -- end List<Node> mixins.
 
   // TODO(jacobr): benchmark whether this is more efficient or whether caching
   // a local copy of childNodes is more efficient.
   int get length => _this.childNodes.length;
 
-  void set length(int value) {
+  set length(int value) {
     throw new UnsupportedError(
         "Cannot set length on immutable List.");
   }
 
   Node operator[](int index) => _this.childNodes[index];
 
   List<Node> get rawList => _this.childNodes;
 }
 
 
 $(ANNOTATIONS)$(NATIVESPEC)$(CLASS_MODIFIERS)class $CLASSNAME$EXTENDS$IMPLEMENTS {
 
   // Custom element created callback.
   Node._created() : super._created();
 
   /**
    * A modifiable list of this node's children.
    */
   List<Node> get nodes {
     return new _ChildNodeListLazy(this);
   }
 
-  void set nodes(Iterable<Node> value) {
+  set nodes(Iterable<Node> value) {
     // Copy list first since we don't want liveness during iteration.
     // TODO(jacobr): there is a better way to do this.
     List copy = new List.from(value);
     text = '';
     for (Node node in copy) {
       append(node);
     }
   }
 
   /**
@@ skipping 55 matching lines @@
   }
 
   /**
    * Print out a String representation of this Node.
    */
   String toString() {
     String value = nodeValue;  // Fetch DOM Node property once.
     return value == null ? super.toString() : value;
   }
 
-$if JSINTEROP
-  List<Node> _childNodes;
-
+$if DARTIUM
   /**
    * A list of this node's children.
    *
    * ## Other resources
    *
    * * [Node.childNodes]
    * (https://developer.mozilla.org/en-US/docs/Web/API/Node.childNodes)
    * from MDN.
    */
   @DomName('Node.childNodes')
   @DocsEditable()
-  List<Node> get childNodes {
-    if (_childNodes == null) {
-       List<Node> nodes = new List<Node>();
-       var jsCollection = _blink.BlinkNode.instance.childNodes_Getter_(unwrap_jso(this));
-       var collectionLen = jsCollection['length'];
-       for (var i = 0; i < collectionLen; i++) {
-         nodes.add(wrap_jso(jsCollection.callMethod('item', [i])));
-       }
-      _childNodes = nodes;
-    }
-    return _childNodes;
-  }
+  List<Node> get childNodes => wrap_jso(_blink.BlinkNode.instance.childNodes_Getter_(unwrap_jso(this)));
 $else
-  $if DARTIUM
   /**
    * A list of this node's children.
    *
-   * ## Other resources
-   *
-   * * [Node.childNodes]
-   * (https://developer.mozilla.org/en-US/docs/Web/API/Node.childNodes)
-   * from MDN.
-   */
-  @DomName('Node.childNodes')
-  @DocsEditable()
-  List<Node> get childNodes => _blink.BlinkNode.instance.childNodes_Getter_(this);
-  $else
-  /**
-   * A list of this node's children.
-   *
    * ## Other resources
    *
    * * [Node.childNodes]
    * (https://developer.mozilla.org/en-US/docs/Web/API/Node.childNodes)
    * from MDN.
    */
   @DomName('Node.childNodes')
   @DocsEditable()
-  @Returns('NodeList')
-  @Creates('NodeList')
   final List<Node> childNodes;
 
-  $endif
 $endif
 $!MEMBERS
 }