Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Issue 1348113004: Add subtract to atomics. (Closed)

Created:
5 years, 3 months ago by herb_g
Modified:
5 years, 3 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M include/core/SkAtomics.h View 2 chunks +7 lines, -0 lines 0 comments Download
M include/ports/SkAtomics_atomic.h View 1 chunk +6 lines, -0 lines 0 comments Download
M include/ports/SkAtomics_std.h View 1 chunk +7 lines, -0 lines 0 comments Download
M include/ports/SkAtomics_sync.h View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
herb_g
There will be a follow on CL to update SharedMutex to use this new atomic.
5 years, 3 months ago (2015-09-16 14:02:01 UTC) #2
mtklein
lgtm, though I'm inclined to think the need for fetch_sub means we might be kidding ...
5 years, 3 months ago (2015-09-16 14:28:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1348113004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1348113004/1
5 years, 3 months ago (2015-09-16 14:31:14 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/2677)
5 years, 3 months ago (2015-09-16 14:32:17 UTC) #7
herb_g
You are right for when the atomic is the entire datum, but if the datum ...
5 years, 3 months ago (2015-09-16 14:40:43 UTC) #8
mtklein
On 2015/09/16 14:40:43, herb_g wrote: > You are right for when the atomic is the ...
5 years, 3 months ago (2015-09-16 14:42:21 UTC) #10
reed1
lgtm
5 years, 3 months ago (2015-09-16 14:43:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1348113004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1348113004/1
5 years, 3 months ago (2015-09-16 14:45:44 UTC) #13
commit-bot: I haz the power
5 years, 3 months ago (2015-09-16 14:46:22 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/3667d5bf3f6d8eea90142046202c4f61cfcd5fea

Powered by Google App Engine
This is Rietveld 408576698