Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Unified Diff: src/compiler/graph-visualizer.cc

Issue 1348073002: [turbofan] Get rid of type lower bounds. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/change-lowering.cc ('k') | src/compiler/js-builtin-reducer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/graph-visualizer.cc
diff --git a/src/compiler/graph-visualizer.cc b/src/compiler/graph-visualizer.cc
index 74b1eaef10a4c9db28ca49e0254ebbfc3240605c..07ca04532bcaa3c94c95ea9d3b380d8167569f7c 100644
--- a/src/compiler/graph-visualizer.cc
+++ b/src/compiler/graph-visualizer.cc
@@ -127,13 +127,10 @@ class JSONGraphNodeWriter {
os_ << ",\"control\":" << (NodeProperties::IsControl(node) ? "true"
: "false");
if (NodeProperties::IsTyped(node)) {
- Bounds bounds = NodeProperties::GetBounds(node);
- std::ostringstream upper;
- bounds.upper->PrintTo(upper);
- std::ostringstream lower;
- bounds.lower->PrintTo(lower);
- os_ << ",\"upper_type\":\"" << Escaped(upper, "\"") << "\"";
- os_ << ",\"lower_type\":\"" << Escaped(lower, "\"") << "\"";
+ Type* type = NodeProperties::GetType(node);
+ std::ostringstream type_out;
+ type->PrintTo(type_out);
+ os_ << ",\"type\":\"" << Escaped(type_out, "\"") << "\"";
}
os_ << "}";
}
@@ -302,12 +299,10 @@ void GraphVisualizer::PrintNode(Node* node, bool gray) {
os_ << "}";
if (FLAG_trace_turbo_types && NodeProperties::IsTyped(node)) {
- Bounds bounds = NodeProperties::GetBounds(node);
- std::ostringstream upper;
- bounds.upper->PrintTo(upper);
- std::ostringstream lower;
- bounds.lower->PrintTo(lower);
- os_ << "|" << Escaped(upper) << "|" << Escaped(lower);
+ Type* type = NodeProperties::GetType(node);
+ std::ostringstream type_out;
+ type->PrintTo(type_out);
+ os_ << "|" << Escaped(type_out);
}
os_ << "}\"\n";
@@ -545,11 +540,9 @@ void GraphC1Visualizer::PrintInputs(Node* node) {
void GraphC1Visualizer::PrintType(Node* node) {
if (NodeProperties::IsTyped(node)) {
- Bounds bounds = NodeProperties::GetBounds(node);
+ Type* type = NodeProperties::GetType(node);
os_ << " type:";
- bounds.upper->PrintTo(os_);
- os_ << "..";
- bounds.lower->PrintTo(os_);
+ type->PrintTo(os_);
}
}
« no previous file with comments | « src/compiler/change-lowering.cc ('k') | src/compiler/js-builtin-reducer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698