Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1348023004: have raster-image return itself as a texture (Closed)

Created:
5 years, 3 months ago by reed1
Modified:
5 years, 3 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

have raster-image return itself as a texture This tickles skbug.com/4351, but we don't know how to fix that yet, so we think this CL is ok. BUG=skia: Committed: https://skia.googlesource.com/skia/+/746f31f18037c12f9fb79fbfb0cc0bbafc204484

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : removed premature simplification to SkGpuDevice #

Total comments: 2

Patch Set 4 : remove unneeded includes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -5 lines) Patch
M src/image/SkImage_Base.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M src/image/SkImage_Raster.cpp View 1 2 3 3 chunks +33 lines, -1 line 0 comments Download

Messages

Total messages: 17 (7 generated)
reed1
5 years, 3 months ago (2015-09-16 17:39:26 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1348023004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1348023004/20001
5 years, 3 months ago (2015-09-16 17:40:43 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-16 17:46:30 UTC) #6
reed1
ptal
5 years, 3 months ago (2015-09-16 19:17:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1348023004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1348023004/40001
5 years, 3 months ago (2015-09-16 19:17:41 UTC) #9
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 3 months ago (2015-09-16 19:17:42 UTC) #10
robertphillips
lgtm + nit https://codereview.chromium.org/1348023004/diff/40001/src/image/SkImage_Raster.cpp File src/image/SkImage_Raster.cpp (right): https://codereview.chromium.org/1348023004/diff/40001/src/image/SkImage_Raster.cpp#newcode22 src/image/SkImage_Raster.cpp:22: #include "GrTextureAccess.h" Do we need GrYUVProvider.h ...
5 years, 3 months ago (2015-09-16 19:42:03 UTC) #11
reed1
https://codereview.chromium.org/1348023004/diff/40001/src/image/SkImage_Raster.cpp File src/image/SkImage_Raster.cpp (right): https://codereview.chromium.org/1348023004/diff/40001/src/image/SkImage_Raster.cpp#newcode22 src/image/SkImage_Raster.cpp:22: #include "GrTextureAccess.h" On 2015/09/16 19:42:03, robertphillips wrote: > Do ...
5 years, 3 months ago (2015-09-16 19:47:26 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1348023004/30004 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1348023004/30004
5 years, 3 months ago (2015-09-16 19:47:42 UTC) #16
commit-bot: I haz the power
5 years, 3 months ago (2015-09-16 19:53:32 UTC) #17
Message was sent while issue was closed. 
Committed patchset #4 (id:30004) as
https://skia.googlesource.com/skia/+/746f31f18037c12f9fb79fbfb0cc0bbafc204484

Powered by Google App Engine
This is Rietveld 408576698