Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(742)

Issue 1347993002: Revert of Revert "Remove obsolete LTR scrollbar padding hack." (Closed)

Created:
5 years, 3 months ago by wkorman
Modified:
5 years, 3 months ago
Reviewers:
chrishtr, szager1
CC:
blink-reviews, blink-reviews-layout_chromium.org, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Revert "Remove obsolete LTR scrollbar padding hack." (patchset #3 id:40001 of https://codereview.chromium.org/1334383002/ ) Reason for revert: Reverting to restore ToT to the way it was. This change served only to provide a change to CP to the release branch. Original issue's description: > Revert "Remove obsolete LTR scrollbar padding hack." > > This reverts commit 0e054f07273d9f5104b4b3926dc438fa794436fe. > > Causes caret to disappear at edge of input fields in some situations. > > BUG=523969, 474759 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=202221 TBR=chrishtr@chromium.org,szager@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=523969, 474759

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -45 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -35 lines 0 comments Download
M LayoutTests/editing/input/editable-container-with-word-wrap-normal.html View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/layout/LayoutBlockFlowLine.cpp View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
wkorman
Created Revert of Revert "Remove obsolete LTR scrollbar padding hack."
5 years, 3 months ago (2015-09-16 03:51:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1347993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1347993002/1
5 years, 3 months ago (2015-09-16 03:51:58 UTC) #2
commit-bot: I haz the power
5 years, 3 months ago (2015-09-16 03:52:24 UTC) #4
Failed to apply patch for LayoutTests/TestExpectations:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file LayoutTests/TestExpectations
  Hunk #1 FAILED at 923.
  1 out of 1 hunk FAILED -- saving rejects to file
LayoutTests/TestExpectations.rej

Patch:       LayoutTests/TestExpectations
Index: LayoutTests/TestExpectations
diff --git a/LayoutTests/TestExpectations b/LayoutTests/TestExpectations
index
5132b5bc69abf695baf179c06d2293e9f4ced7c0..3b8e4eb07aef80ba006ddc07981fef410902fe81
100644
--- a/LayoutTests/TestExpectations
+++ b/LayoutTests/TestExpectations
@@ -923,41 +923,6 @@
 crbug.com/479533 accessibility/show-context-menu.html [ Skip ]
 crbug.com/479533 accessibility/show-context-menu-shadowdom.html [ Skip ]
 crbug.com/483653 accessibility/scroll-containers.html [ Skip ]
-
-crbug.com/474759 css3/selectors3/html/css3-modsel-23.html [ NeedsRebaseline ]
-crbug.com/474759 css3/selectors3/html/css3-modsel-69.html [ NeedsRebaseline ]
-crbug.com/474759 css3/selectors3/xhtml/css3-modsel-23.xml [ NeedsRebaseline ]
-crbug.com/474759 css3/selectors3/xhtml/css3-modsel-69.xml [ NeedsRebaseline ]
-crbug.com/474759 css3/selectors3/xml/css3-modsel-23.xml [ NeedsRebaseline ]
-crbug.com/474759 css3/selectors3/xml/css3-modsel-69.xml [ NeedsRebaseline ]
-crbug.com/474759 editing/input/caret-at-the-edge-of-contenteditable.html [
NeedsRebaseline ]
-crbug.com/474759 editing/input/caret-at-the-edge-of-input.html [
NeedsRebaseline ]
-crbug.com/474759 editing/input/editable-container-with-word-wrap-normal.html [
NeedsRebaseline ]
-crbug.com/474759 editing/pasteboard/drop-text-without-selection.html [
NeedsRebaseline ]
-crbug.com/474759 fast/clip/outline-overflowClip.html [ NeedsRebaseline ]
-crbug.com/474759 fast/css/text-overflow-input.html [ NeedsRebaseline ]
-crbug.com/474759 fast/events/autoscroll.html [ NeedsRebaseline ]
-crbug.com/474759 fast/forms/basic-inputs.html [ NeedsRebaseline ]
-crbug.com/474759 fast/forms/control-restrict-line-height.html [ NeedsRebaseline
]
-crbug.com/474759 fast/forms/input-appearance-preventDefault.html [
NeedsRebaseline ]
-crbug.com/474759 fast/forms/input-appearance-selection.html [ NeedsRebaseline ]
-crbug.com/474759 fast/forms/input-disabled-color.html [ NeedsRebaseline ]
-crbug.com/474759 fast/forms/input-text-drag-down.html [ NeedsRebaseline ]
-crbug.com/474759 fast/forms/input-text-scroll-left-on-blur.html [
NeedsRebaseline ]
-crbug.com/474759 fast/forms/input-text-word-wrap.html [ NeedsRebaseline ]
-crbug.com/474759 fast/forms/input-type-text-min-width.html [ NeedsRebaseline ]
-crbug.com/474759 fast/forms/minWidthPercent.html [ NeedsRebaseline ]
-crbug.com/474759 fast/forms/tabbing-input-iframe.html [ NeedsRebaseline ]
-crbug.com/474759 fast/forms/textfield-outline.html [ NeedsRebaseline ]
-crbug.com/474759 fast/overflow/overflow-focus-ring.html [ NeedsRebaseline ]
-crbug.com/474759 fast/repaint/caret-invalidation-in-overflow-scroll.html [
NeedsRebaseline ]
-crbug.com/474759 fast/replaced/width100percent-searchfield.html [
NeedsRebaseline ]
-crbug.com/474759 fast/replaced/width100percent-textfield.html [ NeedsRebaseline
]
-crbug.com/474759 tables/mozilla/bugs/bug59354.html [ NeedsRebaseline ]
-crbug.com/474759 tables/mozilla/bugs/bug96334.html [ NeedsRebaseline ]
-crbug.com/474759 fast/css/input-search-padding.html [ NeedsRebaseline ]
-crbug.com/474759 virtual/pointerevent/fast/events/autoscroll.html [
NeedsRebaseline ]
-crbug.com/474759 virtual/trustedeventsdefaultaction/fast/events/autoscroll.html
[ NeedsRebaseline ]
 
 crbug.com/491764 http/tests/inspector/service-workers/user-agent-override.html
[ Timeout ]
 crbug.com/474798 fast/repaint/align-self-change-keeping-geometry-grid.html [
Failure ]

Powered by Google App Engine
This is Rietveld 408576698