Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 1347973006: Return const by ref instead of value (Closed)

Created:
5 years, 3 months ago by tanay.c
Modified:
5 years, 3 months ago
Reviewers:
pdr.
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Return const by ref instead of value BUG=393155 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=202576

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M public/platform/WebCryptoAlgorithmParams.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
tanay.c
PTAL
5 years, 3 months ago (2015-09-18 11:03:50 UTC) #2
pdr.
LGTM
5 years, 3 months ago (2015-09-20 02:22:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1347973006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1347973006/1
5 years, 3 months ago (2015-09-21 04:55:17 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-21 06:10:21 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=202576

Powered by Google App Engine
This is Rietveld 408576698