Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 1347893002: Add WebElement::isEditable. (Closed)

Created:
5 years, 3 months ago by esprehn
Modified:
5 years, 3 months ago
Reviewers:
dglazkov, ojan
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add WebElement::isEditable. This will replace RenderViewImpl::IsEditableNode, and fixes bugs where for example a <fieldset disabled> would not be accounted for. It also adds tests for this API. R=dglazkov@chromium.org Committed: https://crrev.com/8891dc44eda41de9755e2ef86f64b3a9d28b5a9a git-svn-id: svn://svn.chromium.org/blink/trunk@202307 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -6 lines) Patch
M Source/core/dom/Node.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/Node.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/WebElement.cpp View 2 chunks +22 lines, -1 line 0 comments Download
M Source/web/WebElementTest.cpp View 2 chunks +38 lines, -1 line 0 comments Download
M public/web/WebElement.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
esprehn
5 years, 3 months ago (2015-09-15 23:50:56 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1347893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1347893002/1
5 years, 3 months ago (2015-09-15 23:51:13 UTC) #4
dglazkov
lgtm
5 years, 3 months ago (2015-09-15 23:51:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1347893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1347893002/1
5 years, 3 months ago (2015-09-16 00:16:42 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=202307
5 years, 3 months ago (2015-09-16 01:32:44 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:52:33 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8891dc44eda41de9755e2ef86f64b3a9d28b5a9a

Powered by Google App Engine
This is Rietveld 408576698