Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 1347873003: Revert of [heap] Introduce parallel compaction algorithm. (Closed)

Created:
5 years, 3 months ago by Michael Lippautz
Modified:
5 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@counters-2nd-try
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Introduce parallel compaction algorithm. (patchset #9 id:160001 of https://codereview.chromium.org/1343333002/ ) Reason for revert: Check failed: https://chromegw.corp.google.com/i/client.v8/builders/V8%20Win64/builds/5535/steps/Check%20%28flakes%29/logs/IndependentWeakHandle Original issue's description: > [heap] Introduce parallel compaction algorithm. > > - The number of parallel tasks is still 1, i.e., we only compact on the main > thread. > - Remove emergency memory (PagedSpace, and CodeRange) > - Introduce partial compaction of pages. > - Logic for multiple tasks is in place. > > BUG=chromium:524425 > LOG=N > > Committed: https://crrev.com/61ea4f55616d3f7bc2ce049a678f16f7475e03e0 > Cr-Commit-Position: refs/heads/master@{#30787} TBR=hpayer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:524425 Committed: https://crrev.com/7a0a0b8b85e4cdf06795ffea01855b345776b932 Cr-Commit-Position: refs/heads/master@{#30788}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+204 lines, -227 lines) Patch
M src/heap/mark-compact.h View 2 chunks +6 lines, -14 lines 0 comments Download
M src/heap/mark-compact.cc View 10 chunks +92 lines, -143 lines 0 comments Download
M src/heap/spaces.h View 9 chunks +22 lines, -47 lines 0 comments Download
M src/heap/spaces.cc View 8 chunks +84 lines, -23 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Lippautz
Created Revert of [heap] Introduce parallel compaction algorithm.
5 years, 3 months ago (2015-09-17 07:57:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1347873003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1347873003/1
5 years, 3 months ago (2015-09-17 07:58:10 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-17 07:58:23 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 07:58:46 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7a0a0b8b85e4cdf06795ffea01855b345776b932
Cr-Commit-Position: refs/heads/master@{#30788}

Powered by Google App Engine
This is Rietveld 408576698