Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Issue 1347863002: ozone: drm: Fix gbm build with GN (Closed)

Created:
5 years, 3 months ago by spang
Modified:
5 years, 2 months ago
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ozone: drm: Fix gbm build with GN ERROR at //ui/ozone/platform/drm/BUILD.gn:122:3: Replacing nonempty list. configs = [ ":libdrm" ] ^------ This overwrites a previously-defined nonempty list (length 15). See //build/config/BUILDCONFIG.gn:504:13: for previous definition configs = _native_compiler_configs ^----------------------- with another one (length 1). Did you mean "+=" to append instead? If you really want to do this, do BUG=531814 TEST=gn gen gn_ozone --args='target_os="chromeos" use_ozone=true' Committed: https://crrev.com/9eb18f13d6b17d70b0c95ecac09922da5661c07d Cr-Commit-Position: refs/heads/master@{#349061}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M ui/ozone/platform/drm/BUILD.gn View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 20 (8 generated)
spang
5 years, 3 months ago (2015-09-15 23:12:56 UTC) #2
spang
5 years, 3 months ago (2015-09-15 23:13:03 UTC) #4
slan
lgtm
5 years, 3 months ago (2015-09-15 23:16:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1347863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1347863002/1
5 years, 3 months ago (2015-09-15 23:19:11 UTC) #7
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 3 months ago (2015-09-15 23:19:12 UTC) #9
gunsch
drive-by committer rs lgtm (slan's request)
5 years, 3 months ago (2015-09-15 23:23:48 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1347863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1347863002/1
5 years, 3 months ago (2015-09-16 00:50:21 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/63354)
5 years, 3 months ago (2015-09-16 00:58:47 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1347863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1347863002/1
5 years, 3 months ago (2015-09-16 01:25:36 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-16 01:31:26 UTC) #18
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9eb18f13d6b17d70b0c95ecac09922da5661c07d Cr-Commit-Position: refs/heads/master@{#349061}
5 years, 3 months ago (2015-09-16 01:32:27 UTC) #19
commit-bot: I haz the power
5 years, 2 months ago (2015-09-23 12:52:29 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9eb18f13d6b17d70b0c95ecac09922da5661c07d
Cr-Commit-Position: refs/heads/master@{#349061}

Powered by Google App Engine
This is Rietveld 408576698