Issue 1347843002: Make SetTransactionRetryCount actually work.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1347843002: Make SetTransactionRetryCount actually work. (Closed)

Created:
5 years, 3 months ago by Vadim Sh.

Modified:
5 years, 3 months ago

Reviewers:
iannucci

CC:
chromium-reviews, infra-reviews+luci-gae_chromium.org

Base URL:
https://github.com/luci/gae.git@master

Target Ref:
refs/heads/master

Project:
luci-gae

Visibility:
Public.

More Reviews

Description

Make SetTransactionRetryCount actually work. It used to store the state in ephemeral dsImpl object that is minted with each call to datastore.Get(...). Store it in more durable dataStoreData instead. R=iannucci@chromium.org BUG=https://github.com/luci/gae/issues/2 Committed: https://github.com/luci/gae/commit/1edc8ccbbf885cd265e33e4d5f0269be83762550

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -7 lines)			Patch
M	impl/memory/context.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	impl/memory/datastore.go	View	3 chunks	+5 lines, -6 lines	0 comments	Download
M	impl/memory/datastore_data.go	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1347843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1347843002/1

5 years, 3 months ago (2015-09-15 22:21:58 UTC) #4

commit-bot: I haz the power

5 years, 3 months ago (2015-09-15 22:23:02 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://github.com/luci/gae/commit/1edc8ccbbf885cd265e33e4d5f0269be83762550

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages