Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1669)

Unified Diff: fpdfsdk/src/javascript/Consts.cpp

Issue 1347833002: Ensure functions in FXJS_V8 are prefixed by FXJS_. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Rebase, nits, format. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « fpdfsdk/include/jsapi/fxjs_v8.h ('k') | fpdfsdk/src/javascript/Document.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: fpdfsdk/src/javascript/Consts.cpp
diff --git a/fpdfsdk/src/javascript/Consts.cpp b/fpdfsdk/src/javascript/Consts.cpp
index 9574c44730bf472dbbea29ca466de8ff498f7330..acb49662b060a3038401f2e125ff11cb7eb64f81 100644
--- a/fpdfsdk/src/javascript/Consts.cpp
+++ b/fpdfsdk/src/javascript/Consts.cpp
@@ -132,7 +132,8 @@ IMPLEMENT_JS_CLASS_CONST(CJS_Zoomtype, zoomtype)
static void DefineGlobalConstString(v8::Isolate* pIsolate,
const wchar_t* pConstName,
const wchar_t* pValue) {
- JS_DefineGlobalConst(pIsolate, pConstName, JS_NewString(pIsolate, pValue));
+ FXJS_DefineGlobalConst(pIsolate, pConstName,
+ FXJS_NewString(pIsolate, pValue));
}
void CJS_GlobalConsts::DefineJSObjects(v8::Isolate* pIsolate) {
@@ -176,7 +177,7 @@ void DefineGlobalConstStringArray(v8::Isolate* pIsolate,
}
CJS_PropValue prop(pIsolate);
prop << array;
- JS_DefineGlobalConst(pIsolate, sConstName, prop.ToV8Value());
+ FXJS_DefineGlobalConst(pIsolate, sConstName, prop.ToV8Value());
}
void CJS_GlobalArrays::DefineJSObjects(v8::Isolate* pIsolate) {
« no previous file with comments | « fpdfsdk/include/jsapi/fxjs_v8.h ('k') | fpdfsdk/src/javascript/Document.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698