Small optimization to find_unused_resources.py.

Small optimization to find_unused_resources.py.

NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244388

[James Cook, 2014-01-10 21:32:30]

Can you give me an example of a place where both the resource ID and the
filename are duplicated in a .grd file?  I'm a little surprised that this
happens - I would expect duplicate resource ids but different filenames.

Is it for cases where IDR_FOO on Mac points to mac/foo.png and IDR_FOO on Win
points to win/foo.png, and we're just searching for "foo.png"?

Code LGTM, I'm just curious

[Lei Zhang, 2014-01-10 21:38:28]

On 2014/01/10 21:32:30, James Cook wrote:
> Can you give me an example of a place where both the resource ID and the
> filename are duplicated in a .grd file?  I'm a little surprised that this
> happens - I would expect duplicate resource ids but different filenames.
> 
> Is it for cases where IDR_FOO on Mac points to mac/foo.png and IDR_FOO on Win
> points to win/foo.png, and we're just searching for "foo.png"?
> 
> Code LGTM, I'm just curious

For example, in chrome/app/theme/theme_resources.grd we have:

<if expr="is_macosx or is_ios">
  <structure type="chrome_scaled_image" name="IDR_BOOKMARK_BAR_FOLDER"
file="mac/bookmark_bar_folder.png" />
</if>
<if expr="not is_macosx and not is_ios">
  <structure type="chrome_scaled_image" name="IDR_BOOKMARK_BAR_FOLDER"
file="common/bookmark_bar_folder.png" />
</if>

Do to: filename = os.path.basename(filepath), the |key| for both of these are
the same.

[Lei Zhang, 2014-01-10 21:38:37]

On 2014/01/10 21:38:28, Lei Zhang wrote:
> On 2014/01/10 21:32:30, James Cook wrote:
> > Can you give me an example of a place where both the resource ID and the
> > filename are duplicated in a .grd file?  I'm a little surprised that this
> > happens - I would expect duplicate resource ids but different filenames.
> > 
> > Is it for cases where IDR_FOO on Mac points to mac/foo.png and IDR_FOO on
Win
> > points to win/foo.png, and we're just searching for "foo.png"?
> > 
> > Code LGTM, I'm just curious
> 
> For example, in chrome/app/theme/theme_resources.grd we have:
> 
> <if expr="is_macosx or is_ios">
>   <structure type="chrome_scaled_image" name="IDR_BOOKMARK_BAR_FOLDER"
> file="mac/bookmark_bar_folder.png" />
> </if>
> <if expr="not is_macosx and not is_ios">
>   <structure type="chrome_scaled_image" name="IDR_BOOKMARK_BAR_FOLDER"
> file="common/bookmark_bar_folder.png" />
> </if>
> 
> Do to: filename = os.path.basename(filepath), the |key| for both of these are
> the same.

s/Do/Due/

[James Cook, 2014-01-10 22:06:43]

LGTM, thanks!

[commit-bot: I haz the power, 2014-01-10 23:53:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/134783002/1

[commit-bot: I haz the power, 2014-01-11 23:19:20]

Change committed as 244388