Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 1347823005: Rename occlusion_query_ext -> ext_occlusion_query (OcclusionQueryEXT -> EXTOcclusionQuery, etc.). (Closed)

Created:
5 years, 3 months ago by viettrungluu
Modified:
5 years, 3 months ago
Reviewers:
jamesr
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Rename occlusion_query_ext -> ext_occlusion_query (OcclusionQueryEXT -> EXTOcclusionQuery, etc.). Keep a thunk setter for the old name (to be deleted when no one uses it and we've verified it). R=jamesr@chromium.org BUG=#353 Committed: https://chromium.googlesource.com/external/mojo/+/32649a8ad09fdb214fae4180eb7e309303960367

Patch Set 1 #

Patch Set 2 : doh #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -118 lines) Patch
M gpu/command_buffer/build_gles2_cmd_buffer.py View 6 chunks +9 lines, -9 lines 0 comments Download
M mojo/gles2/gles2_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/platform/native/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/public/platform/native/gles2/call_visitor_ext_occlusion_query_autogen.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/platform/native/gles2_impl_ext_occlusion_query_thunks.h View 1 chunk +16 lines, -16 lines 0 comments Download
A mojo/public/platform/native/gles2_impl_ext_occlusion_query_thunks.c View 1 chunk +35 lines, -0 lines 0 comments Download
D mojo/public/platform/native/gles2_impl_occlusion_query_ext_thunks.h View 1 chunk +0 lines, -53 lines 0 comments Download
D mojo/public/platform/native/gles2_impl_occlusion_query_ext_thunks.c View 1 chunk +0 lines, -35 lines 0 comments Download
M shell/native_application_support.cc View 3 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
viettrungluu
5 years, 3 months ago (2015-09-16 16:06:00 UTC) #1
jamesr
lgtm
5 years, 3 months ago (2015-09-16 21:40:13 UTC) #2
viettrungluu
5 years, 3 months ago (2015-09-16 21:41:18 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
32649a8ad09fdb214fae4180eb7e309303960367 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698