Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1042)

Unified Diff: mojo/edk/test/test_utils_posix.cc

Issue 1347783002: Add our own (mojo::util::)ScopedFILE and replace uses of base::ScopedFILE with it. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/edk/test/test_utils_posix.cc
diff --git a/mojo/edk/test/test_utils_posix.cc b/mojo/edk/test/test_utils_posix.cc
index 182aa337edc14b06276d668ed6e0c78a00ae59f1..46f50e27b77bc15b8ff47b7e6cbb3ec8089d3779 100644
--- a/mojo/edk/test/test_utils_posix.cc
+++ b/mojo/edk/test/test_utils_posix.cc
@@ -7,6 +7,7 @@
#include <fcntl.h>
#include <unistd.h>
+#include "base/logging.h"
#include "base/posix/eintr_wrapper.h"
namespace mojo {
@@ -72,17 +73,17 @@ bool NonBlockingRead(const embedder::PlatformHandle& handle,
return true;
}
-embedder::ScopedPlatformHandle PlatformHandleFromFILE(base::ScopedFILE fp) {
+embedder::ScopedPlatformHandle PlatformHandleFromFILE(util::ScopedFILE fp) {
CHECK(fp);
int rv = dup(fileno(fp.get()));
PCHECK(rv != -1) << "dup";
return embedder::ScopedPlatformHandle(embedder::PlatformHandle(rv));
}
-base::ScopedFILE FILEFromPlatformHandle(embedder::ScopedPlatformHandle h,
+util::ScopedFILE FILEFromPlatformHandle(embedder::ScopedPlatformHandle h,
const char* mode) {
CHECK(h.is_valid());
- base::ScopedFILE rv(fdopen(h.release().fd, mode));
+ util::ScopedFILE rv(fdopen(h.release().fd, mode));
PCHECK(rv) << "fdopen";
return rv.Pass();
}

Powered by Google App Engine
This is Rietveld 408576698