Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 1347783002: Add our own (mojo::util::)ScopedFILE and replace uses of base::ScopedFILE with it. (Closed)

Created:
5 years, 3 months ago by viettrungluu
Modified:
5 years, 3 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add our own (mojo::util::)ScopedFILE and replace uses of base::ScopedFILE with it. It's entirely equivalent to base::ScopedFILE. For now, we continue to use base's scoped_ptr, but we could use std::unique_ptr instead in the future. R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/9108b3c3359fc3f2b08094a1a53327f1227c3bea

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -30 lines) Patch
M mojo/edk/embedder/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
M mojo/edk/embedder/platform_channel_pair_posix_unittest.cc View 6 chunks +5 lines, -5 lines 0 comments Download
M mojo/edk/embedder/simple_platform_shared_buffer_posix.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/edk/system/BUILD.gn View 1 chunk +1 line, -0 lines 1 comment Download
M mojo/edk/system/multiprocess_message_pipe_unittest.cc View 4 chunks +3 lines, -3 lines 0 comments Download
M mojo/edk/system/platform_handle_dispatcher_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/edk/system/raw_channel_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M mojo/edk/system/remote_message_pipe_unittest.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M mojo/edk/test/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
M mojo/edk/test/test_utils.h View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/edk/test/test_utils_posix.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M mojo/edk/test/test_utils_win.cc View 3 chunks +3 lines, -3 lines 0 comments Download
A mojo/edk/util/BUILD.gn View 1 chunk +22 lines, -0 lines 0 comments Download
A mojo/edk/util/scoped_file.h View 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
viettrungluu
5 years, 3 months ago (2015-09-15 19:59:19 UTC) #1
vardhan
lgtm https://codereview.chromium.org/1347783002/diff/1/mojo/edk/system/BUILD.gn File mojo/edk/system/BUILD.gn (right): https://codereview.chromium.org/1347783002/diff/1/mojo/edk/system/BUILD.gn#newcode222 mojo/edk/system/BUILD.gn:222: "../util", I think it might be safer to ...
5 years, 3 months ago (2015-09-15 21:48:29 UTC) #2
viettrungluu
On 2015/09/15 21:48:29, vardhan wrote: > lgtm > > https://codereview.chromium.org/1347783002/diff/1/mojo/edk/system/BUILD.gn > File mojo/edk/system/BUILD.gn (right): > ...
5 years, 3 months ago (2015-09-15 21:51:13 UTC) #3
viettrungluu
5 years, 3 months ago (2015-09-15 21:52:03 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9108b3c3359fc3f2b08094a1a53327f1227c3bea (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698