Include external touchscreen vid/pid in UMA hardware profile

chrome/browser/metrics/metrics_log.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/metrics/metrics_log.h"
 
 #include <algorithm>
 #include <string>
 #include <vector>
 
+#include "ash/shell.h"

[Alexei Svitkine (slow), 2014/01/28 16:01:06]

Is this header valid to include on all platforms? I thought ash was a ChromeOS
(or Aura) only thing? Probably should be in an ifdef.

 #include "base/base64.h"
 #include "base/basictypes.h"
 #include "base/bind.h"
 #include "base/cpu.h"
 #include "base/lazy_instance.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/prefs/pref_registry_simple.h"
 #include "base/prefs/pref_service.h"
 #include "base/profiler/alternate_timer.h"
 #include "base/sha1.h"
@@ skipping 22 matching lines @@
 #include "chrome/common/pref_names.h"
 #include "chrome/installer/util/google_update_settings.h"
 #include "components/nacl/common/nacl_process_type.h"
 #include "content/public/browser/gpu_data_manager.h"
 #include "content/public/common/content_client.h"
 #include "content/public/common/webplugininfo.h"
 #include "device/bluetooth/bluetooth_adapter.h"
 #include "device/bluetooth/bluetooth_adapter_factory.h"
 #include "device/bluetooth/bluetooth_device.h"
 #include "gpu/config/gpu_info.h"
+#include "ui/events/event_utils.h"
 #include "ui/gfx/screen.h"
 #include "url/gurl.h"
 
 #if defined(OS_ANDROID)
 #include "base/android/build_info.h"
 #endif
 
 #if defined(OS_WIN)
 #include "base/win/metro.h"
 
 // http://blogs.msdn.com/oldnewthing/archive/2004/10/25/247180.aspx
 extern "C" IMAGE_DOS_HEADER __ImageBase;
 #endif
 
 #if defined(OS_CHROMEOS)
 #include "chrome/browser/chromeos/login/user_manager.h"
+#include "ui/events/x/touch_factory_x11.h"
 #endif
 
 using content::GpuDataManager;
 using metrics::OmniboxEventProto;
 using metrics::PerfDataProto;
 using metrics::ProfilerEventProto;
 using metrics::SystemProfileProto;
 using tracked_objects::ProcessDataSnapshot;
 typedef chrome_variations::ActiveGroupId ActiveGroupId;
 typedef SystemProfileProto::GoogleUpdate::ProductInfo ProductInfo;
@@ skipping 294 matching lines @@
       return PairedDevice::DEVICE_MOUSE;
     case device::BluetoothDevice::DEVICE_TABLET:
       return PairedDevice::DEVICE_TABLET;
     case device::BluetoothDevice::DEVICE_KEYBOARD_MOUSE_COMBO:
       return PairedDevice::DEVICE_KEYBOARD_MOUSE_COMBO;
   }
 
   NOTREACHED();
   return PairedDevice::DEVICE_UNKNOWN;
 }
+
+void WriteExternalTouchscreensProto(SystemProfileProto::Hardware* hardware) {
+  std::set<std::pair<int, int> > touchscreen_ids =
+      ui::TouchFactory::GetInstance()->GetTouchscreenIds();
+  for (std::set<std::pair<int, int> >::iterator it = touchscreen_ids.begin();
+       it != touchscreen_ids.end();
+       ++it) {
+    SystemProfileProto::Hardware::TouchScreen* touchscreen =
+        hardware->add_external_touchscreen();
+    touchscreen->set_vendor_id(it->first);
+    touchscreen->set_product_id(it->second);
+  }
+}
 #endif  // defined(OS_CHROMEOS)
 
 // Round a timestamp measured in seconds since epoch to one with a granularity
 // of an hour. This can be used before uploaded potentially sensitive
 // timestamps.
 int64 RoundSecondsToHour(int64 time_in_seconds) {
   return 3600 * (time_in_seconds / 3600);
 }
 
 }  // namespace
@@ skipping 401 matching lines @@
   GetFieldTrialIds(&field_trial_ids);
   WriteFieldTrials(field_trial_ids, system_profile);
   WriteFieldTrials(synthetic_trials, system_profile);
 
 #if defined(OS_CHROMEOS)
   PerfDataProto perf_data_proto;
   if (perf_provider_.GetPerfData(&perf_data_proto))
     uma_proto()->add_perf_data()->Swap(&perf_data_proto);
 
   WriteBluetoothProto(hardware);
+  gfx::Display::TouchSupport has_touch = ui::GetInternalDisplayTouchSupport();

[Alexei Svitkine (slow), 2014/01/28 16:01:06]

I think this ChromeOS-specific code in this class has tipped to a point that it
should be moved out of MetricsService into a helper class. That class can then
be a member var of MetricsService (on ChromeOS) and have a single function -
i.e. WriteChromeOSMetrics().

Can you do this refactoring?

+  if (has_touch == gfx::Display::TOUCH_SUPPORT_AVAILABLE)
+    hardware->set_internal_display_supports_touch(true);
+  else if (has_touch == gfx::Display::TOUCH_SUPPORT_UNAVAILABLE)
+    hardware->set_internal_display_supports_touch(false);
+  WriteExternalTouchscreensProto(hardware);
   UpdateMultiProfileUserCount();
 #endif
 
   std::string serialied_system_profile;
   std::string base64_system_profile;
   if (system_profile->SerializeToString(&serialied_system_profile)) {
     base::Base64Encode(serialied_system_profile, &base64_system_profile);
     PrefService* local_state = GetPrefService();
     local_state->SetString(prefs::kStabilitySavedSystemProfile,
                            base64_system_profile);
@@ skipping 191 matching lines @@
 
     // We invalidate the user count if it changed while the log was open.
     if (system_profile->has_multi_profile_user_count() &&
         user_count != system_profile->multi_profile_user_count())
       user_count = 0;
 
     system_profile->set_multi_profile_user_count(user_count);
   }
 }
 #endif