Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: pkg/watcher/lib/src/directory_watcher/mac_os.dart

Issue 134773002: Stop working around issue 15458 in pkg/watcher. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/watcher/lib/src/directory_watcher/mac_os.dart
diff --git a/pkg/watcher/lib/src/directory_watcher/mac_os.dart b/pkg/watcher/lib/src/directory_watcher/mac_os.dart
index 90036ccc4d8e279aa73b7a5a588e65413fbc1957..17c25adbc070e65c65ca0a0dfffae120adf3fd0e 100644
--- a/pkg/watcher/lib/src/directory_watcher/mac_os.dart
+++ b/pkg/watcher/lib/src/directory_watcher/mac_os.dart
@@ -24,7 +24,7 @@ import 'resubscribable.dart';
/// succession, it won't report them in the order they occurred. See issue
/// 14373.
///
-/// This also works around issues 15458 and 14849 in the implementation of
+/// This also works around issue 14849 in the implementation of
/// [Directory.watch].
class MacOSDirectoryWatcher extends ResubscribableDirectoryWatcher {
// TODO(nweiz): remove these when issue 15042 is fixed.
@@ -295,9 +295,6 @@ class _MacOSDirectoryWatcher implements ManuallyClosedDirectoryWatcher {
case FileSystemEvent.CREATE:
return new ConstructableFileSystemCreateEvent(batch.first.path, isDir);
case FileSystemEvent.DELETE:
- // Issue 15458 means that DELETE events for directories can actually
- // mean CREATE, so we always check the filesystem for them.
- if (isDir) return null;
return new ConstructableFileSystemCreateEvent(batch.first.path, false);
case FileSystemEvent.MODIFY:
return new ConstructableFileSystemModifyEvent(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698