Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: runtime/vm/service/vmservice.dart

Issue 1347693004: getIsolate rpc now returns collected sentinel for expired isolate. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/service/service.md ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/service/vmservice.dart
diff --git a/runtime/vm/service/vmservice.dart b/runtime/vm/service/vmservice.dart
index 4c12cdb1105e398fcef1fec59f6054aae7679f61..5fec8d168a77e65a1451cb64b6304a9e48f26ceb 100644
--- a/runtime/vm/service/vmservice.dart
+++ b/runtime/vm/service/vmservice.dart
@@ -51,6 +51,16 @@ String encodeRpcError(Message message, int code, {String details}) {
return JSON.encode(response);
}
+String encodeResult(Message message, Map result) {
+ var response = {
+ 'jsonrpc': '2.0',
+ 'id' : message.serial,
+ 'result' : result,
+ };
+ return JSON.encode(response);
+}
+
+
class VMService extends MessageRouter {
static VMService _instance;
@@ -173,15 +183,6 @@ class VMService extends MessageRouter {
message.setResponse(JSON.encode(result));
}
- String _encodeResult(Message message, Map result) {
- var response = {
- 'jsonrpc': '2.0',
- 'id' : message.serial,
- 'result' : result,
- };
- return JSON.encode(response);
- }
-
bool _isAnyClientSubscribed(String streamId) {
for (var client in clients) {
if (client.streams.contains(streamId)) {
@@ -208,7 +209,7 @@ class VMService extends MessageRouter {
client.streams.add(streamId);
var result = { 'type' : 'Success' };
- return _encodeResult(message, result);
+ return encodeResult(message, result);
}
Future<String> _streamCancel(Message message) async {
@@ -224,7 +225,7 @@ class VMService extends MessageRouter {
}
var result = { 'type' : 'Success' };
- return _encodeResult(message, result);
+ return encodeResult(message, result);
}
// TODO(johnmccutchan): Turn this into a command line tool that uses the
@@ -282,7 +283,7 @@ class VMService extends MessageRouter {
}
// Encode the entire crash dump.
- return _encodeResult(message, responses);
+ return encodeResult(message, responses);
}
Future<String> route(Message message) {
« no previous file with comments | « runtime/vm/service/service.md ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698