Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(814)

Unified Diff: runtime/vm/service/service.md

Issue 1347693004: getIsolate rpc now returns collected sentinel for expired isolate. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/service/running_isolates.dart ('k') | runtime/vm/service/vmservice.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/service/service.md
diff --git a/runtime/vm/service/service.md b/runtime/vm/service/service.md
index b390460107eae1807d04848107a2ab2b45936abc..5aeab8667b622328519e333c38bfa765ab450cf6 100644
--- a/runtime/vm/service/service.md
+++ b/runtime/vm/service/service.md
@@ -478,18 +478,21 @@ See [FlagList](#flaglist).
### getIsolate
```
-Isolate getIsolate(string isolateId)
+Isolate|Sentinel getIsolate(string isolateId)
```
The _getIsolate_ RPC is used to lookup an _Isolate_ object by its _id_.
+If _isolateId_ refers to an isolate which has exited, then the
+_Collected_ [Sentinel](#sentinel) is returned.
+
See [Isolate](#isolate).
### getObject
```
-Object|Sentinel getObject(string isolateId,
- string objectId)
+Object|Sentinel getObject(string isolateId,
+ string objectId)
```
The _getObject_ RPC is used to lookup an _object_ from some isolate by
@@ -2113,7 +2116,7 @@ version | comments
------- | --------
1.0 draft 1 | initial revision
1.1 | Describe protocol version 2.0.
-1.2 | Describe protocol version 3.0. Added UnresolvedSourceLocation.
+1.2 | Describe protocol version 3.0. Added UnresolvedSourceLocation. Added Sentinel return to getIsolate.
[discuss-list]: https://groups.google.com/a/dartlang.org/forum/#!forum/observatory-discuss
« no previous file with comments | « runtime/vm/service/running_isolates.dart ('k') | runtime/vm/service/vmservice.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698