Check that symbol names in symbol tables are unique.

Check that symbol names in symbol tables are unique.

Makes sure that names within a symbol table are unique. Also cleans
up error reporting to be more consistent between symbol tables.

BUG= https://code.google.com/p/nativeclient/issues/detail?id=4301
R=stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=52863b13f2dfa1659f12f49154bcb13ec218f114

[Karl, 2015-09-15 20:14:48]

kschimpf@google.com changed reviewers:
+ jpp@chromium.org, stichnot@chromium.org

[Jim Stichnoth, 2015-09-15 21:05:29]

https://codereview.chromium.org/1347683003/diff/20001/src/PNaClTranslator.cpp
File src/PNaClTranslator.cpp (right):

https://codereview.chromium.org/1347683003/diff/20001/src/PNaClTranslator.cpp...
src/PNaClTranslator.cpp:39: #include <set>
Can you use unordered_set instead?

https://codereview.chromium.org/1347683003/diff/20001/src/PNaClTranslator.cpp...
src/PNaClTranslator.cpp:1180: typedef std::set<StringType> NamesSetType;
using NamesSetType = std::set<StringType>;

(we're using "using" now instead of typedef)

https://codereview.chromium.org/1347683003/diff/20001/src/PNaClTranslator.cpp...
src/PNaClTranslator.cpp:1192: auto pair = Names.insert(ConvertedName);
capitalize Pair

[Karl, 2015-09-16 17:54:26]

https://codereview.chromium.org/1347683003/diff/20001/src/PNaClTranslator.cpp
File src/PNaClTranslator.cpp (right):

https://codereview.chromium.org/1347683003/diff/20001/src/PNaClTranslator.cpp...
src/PNaClTranslator.cpp:39: #include <set>
On 2015/09/15 21:05:29, stichnot wrote:
> Can you use unordered_set instead?

After figuring out how to define an appropriate hash function, changed to use
unordered set.

https://codereview.chromium.org/1347683003/diff/20001/src/PNaClTranslator.cpp...
src/PNaClTranslator.cpp:1180: typedef std::set<StringType> NamesSetType;
On 2015/09/15 21:05:29, stichnot wrote:
> using NamesSetType = std::set<StringType>;
> 
> (we're using "using" now instead of typedef)

Done.

https://codereview.chromium.org/1347683003/diff/20001/src/PNaClTranslator.cpp...
src/PNaClTranslator.cpp:1192: auto pair = Names.insert(ConvertedName);
On 2015/09/15 21:05:29, stichnot wrote:
> capitalize Pair

Done.

[Jim Stichnoth, 2015-09-16 19:54:37]

lgtm

https://codereview.chromium.org/1347683003/diff/40001/src/PNaClTranslator.cpp
File src/PNaClTranslator.cpp (right):

https://codereview.chromium.org/1347683003/diff/40001/src/PNaClTranslator.cpp...
src/PNaClTranslator.cpp:51: } // end of namespace std.
no period, for consistency

[Karl, 2015-09-16 20:51:25]

Committed patchset #4 (id:60001) manually as
52863b13f2dfa1659f12f49154bcb13ec218f114 (presubmit successful).

[Karl, 2015-09-16 20:51:43]

https://codereview.chromium.org/1347683003/diff/40001/src/PNaClTranslator.cpp
File src/PNaClTranslator.cpp (right):

https://codereview.chromium.org/1347683003/diff/40001/src/PNaClTranslator.cpp...
src/PNaClTranslator.cpp:51: } // end of namespace std.
On 2015/09/16 19:54:37, stichnot wrote:
> no period, for consistency

Done.