src/string.js - Issue 1347663002: [es6] Move builtin constructors for primitives to strict mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/string.js

Issue 1347663002: [es6] Move builtin constructors for primitives to strict mode. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/string.js

diff --git a/src/string.js b/src/string.js

index a8a9e8bd3af67f0878f4a8b34ce9c8cf49793c6d..20d9a44fc4c20d54722e2e9aec59a9507623ec27 100644

--- a/src/string.js

+++ b/src/string.js

@@ -36,6 +36,7 @@ utils.Import(function(from) {

//-------------------------------------------------------------------

function StringConstructor(x) {

+ "use strict";

Michael Starzinger 2015/09/15 13:09:58 nit: Let's add a TODO here that this should at som

if (%_ArgumentsLength() == 0) x = '';

if (%_IsConstructCall()) {

%_SetValueOf(this, TO_STRING_INLINE(x));

« no previous file with comments | « no previous file | src/symbol.js » ('j') | src/symbol.js » ('J')