Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 1347663002: [es6] Move builtin constructors for primitives to strict mode. (Closed)

Created:
5 years, 3 months ago by Benedikt Meurer
Modified:
5 years, 3 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Move builtin constructors for primitives to strict mode. The ES6 specification says that "Built-in functions that are ECMAScript function objects must be strict mode functions", which in particular means that you can never test for them using the "caller" field of a sloppy mode function. CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_layout_dbg,v8_linux_nosnap_dbg R=mstarzinger@chromium.org BUG=v8:105 LOG=n Committed: https://crrev.com/e2f1c26982f57411571c4ce41d02f7d56501b208 Cr-Commit-Position: refs/heads/master@{#30750}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address Michi's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M src/string.js View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/v8natives.js View 1 2 chunks +4 lines, -0 lines 0 comments Download
M test/mjsunit/regress/regress-105.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
5 years, 3 months ago (2015-09-15 13:05:15 UTC) #1
Michael Starzinger
LGTM with nits. https://codereview.chromium.org/1347663002/diff/1/src/string.js File src/string.js (right): https://codereview.chromium.org/1347663002/diff/1/src/string.js#newcode39 src/string.js:39: "use strict"; nit: Let's add a ...
5 years, 3 months ago (2015-09-15 13:09:59 UTC) #2
Benedikt Meurer
Addressed comments, thanks!
5 years, 3 months ago (2015-09-15 13:10:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1347663002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1347663002/20001
5 years, 3 months ago (2015-09-15 13:11:05 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-15 14:32:31 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-15 14:32:50 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e2f1c26982f57411571c4ce41d02f7d56501b208
Cr-Commit-Position: refs/heads/master@{#30750}

Powered by Google App Engine
This is Rietveld 408576698