Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1347593002: Delete the now-obsolete ChromeMainDelegateStagingAndroid. (Closed)

Created:
5 years, 3 months ago by newt (away)
Modified:
5 years, 3 months ago
Reviewers:
Yaron
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete the now-obsolete ChromeMainDelegateStagingAndroid. BUG=526335 Committed: https://crrev.com/d78ac334c85387218498b9ccf2a7eff16734fdbe Cr-Commit-Position: refs/heads/master@{#348882}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -34 lines) Patch
D chrome/browser/android/chrome_main_delegate_staging_android.h View 1 chunk +0 lines, -21 lines 0 comments Download
D chrome/browser/android/chrome_main_delegate_staging_android.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Depends on Patchset:

Issue 1322353002 Patch 1

Messages

Total messages: 9 (2 generated)
newt (away)
PTAL
5 years, 3 months ago (2015-09-15 03:26:15 UTC) #2
Yaron
lgtm And so ends a chapter in the life of upstreaming
5 years, 3 months ago (2015-09-15 13:35:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1347593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1347593002/1
5 years, 3 months ago (2015-09-15 13:35:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-15 14:15:19 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d78ac334c85387218498b9ccf2a7eff16734fdbe Cr-Commit-Position: refs/heads/master@{#348882}
5 years, 3 months ago (2015-09-15 14:15:59 UTC) #7
newt (away)
On 2015/09/15 13:35:23, Yaron wrote: > lgtm > > And so ends a chapter in ...
5 years, 3 months ago (2015-09-15 17:01:38 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:44:46 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d78ac334c85387218498b9ccf2a7eff16734fdbe
Cr-Commit-Position: refs/heads/master@{#348882}

Powered by Google App Engine
This is Rietveld 408576698