Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarModelImpl.java

Issue 1347543002: [Android] Fix refresh keyboard shortcut behavior. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarModelImpl.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarModelImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarModelImpl.java
index f40da6d3962036d2409aced07ff92664ba91eee4..3342bdfa92bf187b510c869049d42100b95d3c61 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarModelImpl.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarModelImpl.java
@@ -5,14 +5,19 @@
package org.chromium.chrome.browser.toolbar;
import android.content.Context;
+import android.text.TextUtils;
import org.chromium.base.ApiCompatibilityUtils;
import org.chromium.base.ApplicationStatus;
import org.chromium.chrome.R;
+import org.chromium.chrome.browser.dom_distiller.DomDistillerServiceFactory;
+import org.chromium.chrome.browser.dom_distiller.DomDistillerTabUtils;
import org.chromium.chrome.browser.ntp.NewTabPage;
import org.chromium.chrome.browser.tab.ChromeTab;
import org.chromium.chrome.browser.tab.Tab;
import org.chromium.chrome.browser.toolbar.ToolbarModel.ToolbarModelDelegate;
+import org.chromium.components.dom_distiller.core.DomDistillerService;
+import org.chromium.components.dom_distiller.core.DomDistillerUrlUtils;
import org.chromium.content_public.browser.WebContents;
/**
@@ -71,6 +76,39 @@ class ToolbarModelImpl extends ToolbarModel implements ToolbarDataProvider, Tool
}
@Override
+ public String getText() {
+ String displayText = super.getText();
+
+ if (mTab == null) return displayText;
+
+ String url = mTab.getUrl().trim();
+ if (DomDistillerUrlUtils.isDistilledPage(url)) {
+ if (isStoredArticle(url)) {
+ DomDistillerService domDistillerService =
+ DomDistillerServiceFactory.getForProfile(mTab.getProfile());
+ String originalUrl = domDistillerService.getUrlForEntry(
+ DomDistillerUrlUtils.getValueForKeyInUrl(url, "entry_id"));
+ displayText =
+ DomDistillerTabUtils.getFormattedUrlFromOriginalDistillerUrl(originalUrl);
+ } else if (DomDistillerUrlUtils.getOriginalUrlFromDistillerUrl(url) != null) {
+ String originalUrl = DomDistillerUrlUtils.getOriginalUrlFromDistillerUrl(url);
+ displayText =
+ DomDistillerTabUtils.getFormattedUrlFromOriginalDistillerUrl(originalUrl);
+ }
+ }
+
+ return displayText;
+ }
+
+ private boolean isStoredArticle(String url) {
+ DomDistillerService domDistillerService =
+ DomDistillerServiceFactory.getForProfile(mTab.getProfile());
+ String entryIdFromUrl = DomDistillerUrlUtils.getValueForKeyInUrl(url, "entry_id");
+ if (TextUtils.isEmpty(entryIdFromUrl)) return false;
+ return domDistillerService.hasEntry(entryIdFromUrl);
+ }
+
+ @Override
public boolean isIncognito() {
return mIsIncognito;
}

Powered by Google App Engine
This is Rietveld 408576698