Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Issue 134753008: Performance fixes for CoreAnimation. (Closed)

Created:
6 years, 11 months ago by ccameron
Modified:
6 years, 10 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Performance fixes for CoreAnimation. Consolidate the calls to [NSScreen screens] because this call can take several milliseconds, and use an observer to ensure that this call is only made when the value is changed. Only use a single OpenGL context because using multiple contexts does not improve performance and only adds complexity. BUG=245900 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247621

Patch Set 1 #

Patch Set 2 : Use observer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -15 lines) Patch
M content/browser/renderer_host/compositing_iosurface_mac.mm View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 6 chunks +38 lines, -15 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ccameron
This gets CA performance up where non-CA performance is (and in some cases better). Also, ...
6 years, 10 months ago (2014-01-28 09:17:16 UTC) #1
Avi (use Gerrit)
The screen calls LGTM, the OpenGL call I don't know enough to review. Yeah, you ...
6 years, 10 months ago (2014-01-28 20:12:06 UTC) #2
ccameron
Thanks. I'll add kbr (at F2F) to TBR the GL line. There's actually a huge ...
6 years, 10 months ago (2014-01-29 01:07:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/134753008/20001
6 years, 10 months ago (2014-01-29 01:08:17 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-01-29 05:11:56 UTC) #5
Message was sent while issue was closed.
Change committed as 247621

Powered by Google App Engine
This is Rietveld 408576698