Add flags to python test server for channel id, extended master secret, and token binding

Add flags to python test server for channel id, extended master secret, and token binding

BUG=467312
Committed: https://crrev.com/22e67634e17914c5dddc6ad2649a4bf701908311
Cr-Commit-Position: refs/heads/master@{#349164}

[nharper, 2015-09-14 22:59:34]

nharper@chromium.org changed reviewers:
+ davidben@chromium.org, rsleevi@chromium.org

[nharper, 2015-09-14 22:59:35]

This builds on top of https://codereview.chromium.org/1336143002/ and
https://codereview.chromium.org/1339193002/. Let me know if you'd prefer that I
collapse these down into one cl.

[davidben, 2015-09-15 15:58:36]

https://codereview.chromium.org/1347503002/diff/1/net/test/spawned_test_serve...
File net/test/spawned_test_server/base_test_server.cc (right):

https://codereview.chromium.org/1347503002/diff/1/net/test/spawned_test_serve...
net/test/spawned_test_server/base_test_server.cc:114: void
GetTokenBindingParams(std::vector<int> params, base::ListValue* values) {
Perhaps just have this return a scoped_ptr<base::ListValue>? Would probably be
slightly cleaner at the call site and right now this is more
"AppendTokenBindingParams".

(DictonaryValue has a scoped_ptr<Value> version of Set so you don't need to
.release() or anything.)

https://codereview.chromium.org/1347503002/diff/1/net/tools/testserver/testse...
File net/tools/testserver/testserver.py (right):

https://codereview.chromium.org/1347503002/diff/1/net/tools/testserver/testse...
net/tools/testserver/testserver.py:162: token_binding_params):
No need for this CL, but there may be something to be said for switching this to
pass in the options object or something as this is getting a bit unwieldy...

https://codereview.chromium.org/1347503002/diff/1/net/tools/testserver/testse...
net/tools/testserver/testserver.py:213: [int(param) for param in
token_binding_params]
I think you can avoid explicitly calling int and pass type='int' to add_option.
Does that work?

[nharper, 2015-09-15 23:49:19]

https://codereview.chromium.org/1347503002/diff/1/net/test/spawned_test_serve...
File net/test/spawned_test_server/base_test_server.cc (right):

https://codereview.chromium.org/1347503002/diff/1/net/test/spawned_test_serve...
net/test/spawned_test_server/base_test_server.cc:114: void
GetTokenBindingParams(std::vector<int> params, base::ListValue* values) {
On 2015/09/15 15:58:35, David Benjamin wrote:
> Perhaps just have this return a scoped_ptr<base::ListValue>? Would probably be
> slightly cleaner at the call site and right now this is more
> "AppendTokenBindingParams".
> 
> (DictonaryValue has a scoped_ptr<Value> version of Set so you don't need to
> .release() or anything.)

Done.

https://codereview.chromium.org/1347503002/diff/1/net/tools/testserver/testse...
File net/tools/testserver/testserver.py (right):

https://codereview.chromium.org/1347503002/diff/1/net/tools/testserver/testse...
net/tools/testserver/testserver.py:162: token_binding_params):
On 2015/09/15 15:58:35, David Benjamin wrote:
> No need for this CL, but there may be something to be said for switching this
to
> pass in the options object or something as this is getting a bit unwieldy...

I agree it's getting unwieldy.

https://codereview.chromium.org/1347503002/diff/1/net/tools/testserver/testse...
net/tools/testserver/testserver.py:213: [int(param) for param in
token_binding_params]
On 2015/09/15 15:58:35, David Benjamin wrote:
> I think you can avoid explicitly calling int and pass type='int' to
add_option.
> Does that work?

Yes, that works. Thanks.

[davidben, 2015-09-16 16:26:03]

lgtm

[nharper, 2015-09-16 17:12:55]

The CQ bit was checked by nharper@chromium.org

[commit-bot: I haz the power, 2015-09-16 17:13:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1347503002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1347503002/20001

[commit-bot: I haz the power, 2015-09-16 18:26:00]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-09-16 18:26:52]

Patchset 2 (id:??) landed as
https://crrev.com/22e67634e17914c5dddc6ad2649a4bf701908311
Cr-Commit-Position: refs/heads/master@{#349164}

[tommycli, 2015-09-17 17:25:24]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1351133002/ by tommycli@chromium.org.

The reason for reverting is: This change tripped the Linux Tests (valgrind)
memory bots.

See:
http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20(val...

First failure:
http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28v...

Cause: 
Newly added member variables are not initialized in second constructor.

Thanks and sorry for revert..

[nharper, 2015-09-17 21:30:57]

Updated to fix uninitialized memory error.

[davidben, 2015-09-17 21:34:33]

lgtm. As a follow-up, it might be worth switching these to inline initializers
which I believe we're allowed now. Especially since there's two constructors.

[nharper, 2015-09-17 21:38:52]

The CQ bit was checked by nharper@chromium.org

[commit-bot: I haz the power, 2015-09-17 21:39:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1347503002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1347503002/40001

[commit-bot: I haz the power, 2015-09-18 00:56:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-18 00:56:43]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[nharper, 2015-09-18 19:17:03]

The CQ bit was checked by nharper@chromium.org

[commit-bot: I haz the power, 2015-09-18 19:17:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1347503002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1347503002/40001

[commit-bot: I haz the power, 2015-09-18 19:23:08]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-09-18 19:23:49]

Patchset 3 (id:??) landed as
https://crrev.com/661ba7af493eee0eb89e4b7e4c8817edb20093f9
Cr-Commit-Position: refs/heads/master@{#349736}

[commit-bot: I haz the power, 2015-09-23 12:58:05]

Patchset 3 (id:??) landed as
https://crrev.com/22e67634e17914c5dddc6ad2649a4bf701908311
Cr-Commit-Position: refs/heads/master@{#349164}