Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 1347493004: Recomposite transform animations when CSS zoom changes (Closed)

Created:
5 years, 3 months ago by alancutter (OOO until 2018)
Modified:
5 years, 3 months ago
Reviewers:
dstockwell
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, Eric Willigers, rjwright, shans
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Recomposite transform animations when CSS zoom changes This change ensures we update composited transform animations in response to the CSS zoom level changing so we aren't using outdated transform compositor keyframe values. Note: This scenario continues to be a bug for main thread transform animations. BUG=412538 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=202442

Patch Set 1 #

Patch Set 2 : Use page zoom #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase better #

Total comments: 2

Patch Set 5 : Review changes #

Patch Set 6 : Fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -11 lines) Patch
A + LayoutTests/virtual/threaded/animations/zoom-responsive-transform-animation.html View 1 1 chunk +5 lines, -11 lines 0 comments Download
A LayoutTests/virtual/threaded/animations/zoom-responsive-transform-animation-expected.html View 1 1 chunk +18 lines, -0 lines 0 comments Download
M Source/core/animation/css/CSSAnimations.cpp View 1 2 3 4 5 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (8 generated)
alancutter (OOO until 2018)
5 years, 3 months ago (2015-09-15 11:54:19 UTC) #2
Timothy Loh
Can we test this with page zoom? window.internals has a setZoomFactor function.
5 years, 3 months ago (2015-09-15 11:58:59 UTC) #3
alancutter (OOO until 2018)
On 2015/09/15 at 11:58:59, timloh wrote: > Can we test this with page zoom? window.internals ...
5 years, 3 months ago (2015-09-16 03:10:59 UTC) #4
alancutter (OOO until 2018)
dstockwell: Ping.
5 years, 3 months ago (2015-09-17 02:12:08 UTC) #5
dstockwell
lgtm https://codereview.chromium.org/1347493004/diff/60001/Source/core/animation/css/CSSAnimations.cpp File Source/core/animation/css/CSSAnimations.cpp (right): https://codereview.chromium.org/1347493004/diff/60001/Source/core/animation/css/CSSAnimations.cpp#newcode245 Source/core/animation/css/CSSAnimations.cpp:245: if (oldStyle.effectiveZoom() != style.effectiveZoom()) { early out if ...
5 years, 3 months ago (2015-09-17 04:07:13 UTC) #6
alancutter (OOO until 2018)
https://codereview.chromium.org/1347493004/diff/60001/Source/core/animation/css/CSSAnimations.cpp File Source/core/animation/css/CSSAnimations.cpp (right): https://codereview.chromium.org/1347493004/diff/60001/Source/core/animation/css/CSSAnimations.cpp#newcode245 Source/core/animation/css/CSSAnimations.cpp:245: if (oldStyle.effectiveZoom() != style.effectiveZoom()) { On 2015/09/17 at 04:07:13, ...
5 years, 3 months ago (2015-09-17 04:21:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1347493004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1347493004/80001
5 years, 3 months ago (2015-09-17 04:21:56 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/108527)
5 years, 3 months ago (2015-09-17 05:18:37 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1347493004/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1347493004/100001
5 years, 3 months ago (2015-09-17 07:51:24 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/108577)
5 years, 3 months ago (2015-09-17 09:16:29 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1347493004/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1347493004/100001
5 years, 3 months ago (2015-09-17 10:26:46 UTC) #19
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 11:15:35 UTC) #20
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=202442

Powered by Google App Engine
This is Rietveld 408576698