Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 1347483002: mini_chromium: remove implicit_cast (Closed)

Created:
5 years, 3 months ago by scottmg
Modified:
5 years, 3 months ago
Reviewers:
Mark Mentovai
CC:
crashpad-dev_chromium.org, danakj
Base URL:
https://chromium.googlesource.com/chromium/mini_chromium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

mini_chromium: remove implicit_cast No longer in Chromium base, now in util/misc/implicit_cast.h in Crashpad. R=mark@chromium.org BUG=529769, 472900, crashpad:51 Committed: https://chromium.googlesource.com/chromium/mini_chromium/+/71c2f4d01e52aa0e2fb9bf6118f147905e50e284

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M base/basictypes.h View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scottmg
5 years, 3 months ago (2015-09-14 21:53:27 UTC) #1
Mark Mentovai
LGTM
5 years, 3 months ago (2015-09-14 21:53:54 UTC) #2
scottmg
5 years, 3 months ago (2015-09-14 22:10:20 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
71c2f4d01e52aa0e2fb9bf6118f147905e50e284 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698