Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1347473003: Revert of [crankshaft] Re-add fast-case for string add left/right. (Closed)

Created:
5 years, 3 months ago by Michael Achenbach
Modified:
5 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [crankshaft] Re-add fast-case for string add left/right. (patchset #1 id:1 of https://codereview.chromium.org/1339053002/ ) Reason for revert: [Sheriff] Fails mozilla with deadcode: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20deadcode/builds/5357 Original issue's description: > [crankshaft] Re-add fast-case for string add left/right. > > Now the StringAddStub can optionally convert it's parameters to strings > (following the rules for the addition operator). This could be further > optimized once we have a ToPrimitiveStub, but it should be sufficient > for the moment. > > Also removed the unused Strength parameter to the HStringAdd operator, > because string addition does not depend on language mode. > > CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_win_nosnap_shared_rel,v8_linux_nosnap_dbg > R=mstarzinger@chromium.org > BUG=v8:4307 > LOG=n > > Committed: https://crrev.com/d261849e53fbf8c36efae42d478271f87acff70f > Cr-Commit-Position: refs/heads/master@{#30726} TBR=mstarzinger@chromium.org,jarin@chromium.org,bmeurer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4307 Committed: https://crrev.com/c5a4c39873b2dcb0c79f3f6542a4961f70f7be61 Cr-Commit-Position: refs/heads/master@{#30727}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -97 lines) Patch
M src/code-stubs.h View 3 chunks +5 lines, -9 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 3 chunks +2 lines, -66 lines 0 comments Download
M src/hydrogen.cc View 5 chunks +15 lines, -10 lines 0 comments Download
M src/hydrogen-instructions.h View 2 chunks +4 lines, -3 lines 0 comments Download
M src/hydrogen-instructions.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of [crankshaft] Re-add fast-case for string add left/right.
5 years, 3 months ago (2015-09-15 06:40:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1347473003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1347473003/1
5 years, 3 months ago (2015-09-15 06:40:32 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-15 06:40:42 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-09-15 06:41:03 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c5a4c39873b2dcb0c79f3f6542a4961f70f7be61
Cr-Commit-Position: refs/heads/master@{#30727}

Powered by Google App Engine
This is Rietveld 408576698