Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1347453002: fix a few more codegen issues: (Closed)

Created:
5 years, 3 months ago by Jennifer Messerly
Modified:
5 years, 3 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fix a few more codegen issues: * don't generate script tag * handle U+2028 and U+2029 * handle name conflict with constructor R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/a659f4e8bbab89ab15377092be08315281ba4f6f

Patch Set 1 #

Patch Set 2 : run the tests too #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -18 lines) Patch
M lib/runtime/_classes.js View 1 1 chunk +4 lines, -0 lines 0 comments Download
M lib/runtime/_types.js View 1 2 chunks +2 lines, -4 lines 0 comments Download
M lib/src/codegen/js_codegen.dart View 1 2 chunks +11 lines, -5 lines 0 comments Download
M lib/src/js/builder.dart View 1 chunk +11 lines, -3 lines 0 comments Download
M test/browser/language_tests.js View 1 1 chunk +7 lines, -2 lines 0 comments Download
M test/codegen/expect/html_input.html View 1 chunk +2 lines, -2 lines 2 comments Download
M test/codegen/expect/script.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/codegen/expect/sunflower/sunflower.html View 1 chunk +1 line, -1 line 0 comments Download
A test/codegen/language/naming3_test.dart View 1 1 chunk +47 lines, -0 lines 0 comments Download
A test/codegen/language/optimized_string_charcodeat_test.dart View 1 chunk +81 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Jennifer Messerly
5 years, 3 months ago (2015-09-14 22:24:47 UTC) #2
vsm
lgtm https://codereview.chromium.org/1347453002/diff/20001/test/codegen/expect/html_input.html File test/codegen/expect/html_input.html (right): https://codereview.chromium.org/1347453002/diff/20001/test/codegen/expect/html_input.html#newcode31 test/codegen/expect/html_input.html:31: <script src="dir/html_input_b.js"></script> do you know where these reorderings ...
5 years, 3 months ago (2015-09-14 23:41:59 UTC) #3
Jennifer Messerly
https://codereview.chromium.org/1347453002/diff/20001/test/codegen/expect/html_input.html File test/codegen/expect/html_input.html (right): https://codereview.chromium.org/1347453002/diff/20001/test/codegen/expect/html_input.html#newcode31 test/codegen/expect/html_input.html:31: <script src="dir/html_input_b.js"></script> On 2015/09/14 23:41:59, vsm wrote: > do ...
5 years, 3 months ago (2015-09-14 23:48:43 UTC) #4
Jennifer Messerly
5 years, 3 months ago (2015-09-15 00:06:32 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
a659f4e8bbab89ab15377092be08315281ba4f6f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698