Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1415)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/vm/code_patcher_mips.cc

Issue 13474009: Implements optional parameter handling in MIPS vm. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/vm/assembler_mips_test.cc ('K') | « runtime/vm/assembler_mips_test.cc ('k') | runtime/vm/code_patcher_mips_test.cc » ('j') | runtime/vm/find_code_object_test.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/code_patcher_mips.cc
===================================================================
--- runtime/vm/code_patcher_mips.cc (revision 20887)
+++ runtime/vm/code_patcher_mips.cc (working copy)
@@ -47,13 +47,20 @@
ICData* ic_data,
Array* arguments_descriptor) {
ASSERT(code.ContainsInstructionAt(return_address));
- UNIMPLEMENTED();
- return 0;
+ CallPattern call(return_address, code);
+ if (ic_data != NULL) {
+ *ic_data = call.IcData();
+ }
+ if (arguments_descriptor != NULL) {
+ *arguments_descriptor = call.ArgumentsDescriptor();
+ }
+ return call.TargetAddress();
}
intptr_t CodePatcher::InstanceCallSizeInBytes() {
- UNIMPLEMENTED();
+ // The instance call instruction sequence has a variable size on ARM.
regis 2013/04/03 21:12:39 ARM -> MIPS
zra 2013/04/03 21:41:00 Done.
+ UNREACHABLE();
return 0;
}
« runtime/vm/assembler_mips_test.cc ('K') | « runtime/vm/assembler_mips_test.cc ('k') | runtime/vm/code_patcher_mips_test.cc » ('j') | runtime/vm/find_code_object_test.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698