Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(822)

Unified Diff: runtime/vm/assembler_mips_test.cc

Issue 13474009: Implements optional parameter handling in MIPS vm. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/assembler_mips_test.cc
===================================================================
--- runtime/vm/assembler_mips_test.cc (revision 20887)
+++ runtime/vm/assembler_mips_test.cc (working copy)
@@ -989,6 +989,46 @@
}
+ASSEMBLER_TEST_GENERATE(Label_link1, assembler) {
+ Label l;
+
+ __ bgez(ZR, &l);
+ __ bgez(ZR, &l);
+ __ bgez(ZR, &l);
+
+ __ LoadImmediate(V0, 1);
regis 2013/04/03 21:44:29 You still miss the jr(RA), otherwise 1 is overwrit
+ __ Bind(&l);
+ __ mov(V0, ZR);
+ __ jr(RA);
+}
+
+
+ASSEMBLER_TEST_RUN(Label_link1, test) {
+ typedef int (*SimpleCode)();
+ EXPECT_EQ(0, EXECUTE_TEST_CODE_INT32(SimpleCode, test->entry()));
+}
+
+
+ASSEMBLER_TEST_GENERATE(Label_link2, assembler) {
+ Label l;
+
+ __ beq(ZR, ZR, &l);
+ __ beq(ZR, ZR, &l);
+ __ beq(ZR, ZR, &l);
+
+ __ LoadImmediate(V0, 1);
regis 2013/04/03 21:44:29 ditto
+ __ Bind(&l);
+ __ mov(V0, ZR);
+ __ jr(RA);
+}
+
+
+ASSEMBLER_TEST_RUN(Label_link2, test) {
+ typedef int (*SimpleCode)();
+ EXPECT_EQ(0, EXECUTE_TEST_CODE_INT32(SimpleCode, test->entry()));
+}
+
+
ASSEMBLER_TEST_GENERATE(Jalr_delay, assembler) {
__ mov(R2, RA);
__ jalr(R2, RA);

Powered by Google App Engine
This is Rietveld 408576698