Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1347353003: [turbofan] Checking of input counts on node creation (Closed)

Created:
5 years, 3 months ago by Jarin
Modified:
5 years, 3 months ago
CC:
v8-reviews_googlegroups.com, Michael Starzinger
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Checking of input counts on node creation This required fixing bunch of tests with wrong input counts. Committed: https://crrev.com/260ec46efd74c45cdc4b156d95086b7de06621ad Cr-Commit-Position: refs/heads/master@{#30877}

Patch Set 1 #

Patch Set 2 : Fix unit tests #

Patch Set 3 : Split the CL (no node editor yet) #

Total comments: 4

Patch Set 4 : NewNode -> AddNode #

Unified diffs Side-by-side diffs Delta from patch set Stats (+456 lines, -458 lines) Patch
M src/compiler/basic-block-instrumentor.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/compiler/graph.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/graph.cc View 2 chunks +8 lines, -1 line 0 comments Download
M src/compiler/raw-machine-assembler.h View 1 2 3 12 chunks +115 lines, -139 lines 0 comments Download
M src/compiler/raw-machine-assembler.cc View 1 2 3 15 chunks +33 lines, -48 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +4 lines, -1 line 0 comments Download
M test/cctest/compiler/codegen-tester.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-graph-visualizer.cc View 2 chunks +15 lines, -13 lines 0 comments Download
M test/cctest/compiler/test-js-constant-cache.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/compiler/test-js-context-specialization.cc View 3 chunks +14 lines, -10 lines 0 comments Download
M test/cctest/compiler/test-js-typed-lowering.cc View 4 chunks +24 lines, -14 lines 0 comments Download
M test/cctest/compiler/test-machine-operator-reducer.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-node.cc View 38 chunks +133 lines, -122 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 1 2 3 18 chunks +22 lines, -22 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 1 chunk +4 lines, -1 line 0 comments Download
M test/unittests/compiler/graph-reducer-unittest.cc View 1 2 chunks +7 lines, -4 lines 0 comments Download
M test/unittests/compiler/instruction-selector-unittest.cc View 1 2 3 6 chunks +19 lines, -19 lines 0 comments Download
M test/unittests/compiler/js-context-relaxation-unittest.cc View 1 4 chunks +7 lines, -19 lines 0 comments Download
M test/unittests/compiler/js-type-feedback-unittest.cc View 1 1 chunk +3 lines, -9 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 1 3 chunks +9 lines, -21 lines 0 comments Download
M test/unittests/compiler/liveness-analyzer-unittest.cc View 1 1 chunk +4 lines, -3 lines 0 comments Download
M test/unittests/compiler/loop-peeling-unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/scheduler-unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/typer-unittest.cc View 1 2 chunks +18 lines, -2 lines 0 comments Download
M test/unittests/compiler/value-numbering-reducer-unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Jarin
Could you take a look, please?
5 years, 3 months ago (2015-09-23 06:28:38 UTC) #2
Benedikt Meurer
LGTM with nits. https://codereview.chromium.org/1347353003/diff/40001/src/compiler/raw-machine-assembler.cc File src/compiler/raw-machine-assembler.cc (right): https://codereview.chromium.org/1347353003/diff/40001/src/compiler/raw-machine-assembler.cc#newcode183 src/compiler/raw-machine-assembler.cc:183: return NewNode(common()->Call(descriptor), centry, arg1, ref, arity, ...
5 years, 3 months ago (2015-09-23 06:57:12 UTC) #3
Jarin
https://codereview.chromium.org/1347353003/diff/40001/src/compiler/raw-machine-assembler.cc File src/compiler/raw-machine-assembler.cc (right): https://codereview.chromium.org/1347353003/diff/40001/src/compiler/raw-machine-assembler.cc#newcode183 src/compiler/raw-machine-assembler.cc:183: return NewNode(common()->Call(descriptor), centry, arg1, ref, arity, context, On 2015/09/23 ...
5 years, 3 months ago (2015-09-23 07:09:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1347353003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1347353003/60001
5 years, 3 months ago (2015-09-23 07:30:08 UTC) #7
Michael Starzinger
LGTM.
5 years, 3 months ago (2015-09-23 07:49:00 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 3 months ago (2015-09-23 07:53:51 UTC) #10
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/260ec46efd74c45cdc4b156d95086b7de06621ad Cr-Commit-Position: refs/heads/master@{#30877}
5 years, 3 months ago (2015-09-23 07:53:59 UTC) #11
Michael Achenbach
5 years, 3 months ago (2015-09-23 08:01:27 UTC) #12
Message was sent while issue was closed. 
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1362783004/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Breaks mips cross-compile:
http://build.chromium.org/p/client.v8/builders/V8%20Mips%20-%20builder/builds....

Powered by Google App Engine
This is Rietveld 408576698